Linters should only be run on pull request builds. Once bad code style has been merged into master, it's too late. Master and other branches should not fail to build because of linter warnings.
[travis-ci] Only run linters on Pull Requests #11699
pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:lint_only_prs changing 1 files +1 −1-
jnewbery commented at 10:28 PM on November 15, 2017: member
-
ec85248c48
[travis-ci] Only run linters on Pull Requests
Linters should only be run on pull request builds. Once bad code style has been merged into master, it's too late. Master and other branches should not fail to build because of linter warnings.
-
jnewbery commented at 10:28 PM on November 15, 2017: member
ping @MarcoFalke
- fanquake added the label Tests on Nov 15, 2017
-
MarcoFalke commented at 10:31 PM on November 15, 2017: member
utACK ec85248c4877c273bf51c4e76fab85cbc26013bf
-
fanquake commented at 2:35 AM on November 16, 2017: member
utACK ec85248
-
jonasschnelli commented at 6:27 AM on November 16, 2017: contributor
utACK ec85248c4877c273bf51c4e76fab85cbc26013bf
-
laanwj commented at 10:48 AM on November 16, 2017: member
Yes, thank you. utACK ec85248
- laanwj merged this on Nov 16, 2017
- laanwj closed this on Nov 16, 2017
- laanwj referenced this in commit 66d46c7901 on Nov 16, 2017
-
promag commented at 10:56 AM on November 16, 2017: member
Nice.
- DrahtBot locked this on Sep 8, 2021
Labels