Trim trailing whitespace in src/*.{cpp,h} #1170

pull jgarzik wants to merge 1 commits into bitcoin:master from jgarzik:ws changing 16 files +27 −27
  1. jgarzik commented at 6:58 PM on April 30, 2012: contributor

    This commit changes no code, and makes no other cleanups than removing the trailing whitespace from source code and comment lines.

    Script used: https://gist.github.com/2561322

  2. Trim trailing whitespace in src/*.{cpp,h} 6d82cd66f9
  3. laanwj commented at 7:03 PM on April 30, 2012: member

    I'll never understand this war on spaces. IMO this just breaks other patches for reason at all.

  4. jgarzik commented at 7:16 PM on April 30, 2012: contributor

    It is a very minor change, yes, but it pops up again and again in pull requests for various projects. Sometimes editors automatically trim this stuff, which may generate larger patches (with changes in unexpected areas) down the road.

    Others will submit this stuff, as was already done in #1136, so might as well make our stuff uniform all in one go.

  5. Diapolo commented at 11:31 PM on April 30, 2012: none

    Great big and never-ending ACK ;).

  6. rebroad commented at 5:41 PM on May 2, 2012: contributor

    Well done. Does this mean I'll have more free disk space after applying this?

  7. gmaxwell commented at 6:55 PM on May 5, 2012: contributor

    I think we should pull this in 0.7.0 after pulling most of the other outstanding 0.7.0 pulls that this would break.

  8. Diapolo commented at 10:36 AM on May 6, 2012: none

    I think this should be rebased once more (if needed) and then get merged. Why should this even break pulls, it removes not a single line only spaces?

  9. jgarzik commented at 1:50 PM on May 6, 2012: contributor

    It is scripted, thus may be regenerated from scratch at any time.

  10. sipa commented at 2:12 PM on May 6, 2012: member

    ACK for applying at the end of 0.7.0's merge window.

  11. jgarzik commented at 4:03 PM on June 27, 2012: contributor

    Closing. Will run script to do this immediately prior to 0.7rc1 release...

  12. jgarzik closed this on Jun 27, 2012

  13. Diapolo commented at 4:10 PM on June 27, 2012: none

    I hope so ^^.

  14. jgarzik deleted the branch on Aug 24, 2014
  15. suprnurd referenced this in commit 286f6ad87e on Dec 5, 2017
  16. lateminer referenced this in commit 5f146ffb6d on Jan 22, 2019
  17. DrahtBot locked this on Sep 8, 2021

Milestone
0.7.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-20 00:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me