I'll update this as I figure out how everything is tied together, but I think it's a useful enough start.
[docs] initial QT documentation #11761
pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:qt-docs changing 2 files +95 −17-
Sjors commented at 3:48 PM on November 24, 2017: member
- fanquake added the label Docs and Output on Nov 24, 2017
-
in src/qt/README.md:31 in 2034afd1e0 outdated
42 | + 43 | +Resources such as the icon. 44 | + 45 | +## test 46 | + 47 | +Tests.
MarcoFalke commented at 10:40 PM on November 24, 2017:Not sure if listing folders whose description can be inferred from the name is useful.
Sjors commented at 7:18 AM on November 25, 2017:It's a placeholder. It should explain how to run them, roughly what these tests (don't) cover, and perhaps point to some work in progress on UI tests.
jonasschnelli commented at 7:37 AM on November 25, 2017: contributorNot so sure. I think design documents would be helpful, though may outdate quickly, especially if there are filenames.
Also, we have already a Qt Creator part in OS X build docs (not sure if it belongs there).
promag commented at 11:19 AM on November 25, 2017: memberI guess you should add
WIP:prefix to the title and meanwhile try to improve with useful documentation. Also not sure if that belongs to the source code or to some blog?..fanquake renamed this:[docs] initial QT documentation
[WIP] [docs] initial QT documentation
on Nov 25, 2017fanquake commented at 11:08 PM on November 25, 2017: memberThis seems (so far) to mostly be a collection of documentation/links that are already available in the docs. I don't think there's much benefit in repeating build instructions, or other info that's already available elsewhere, as it just creates an opportunity for information to get out of sync.
I think @jonasschnelli has a point about the Qt Creator stuff that is just tacked onto the OS X build notes. If your going to do this, see if you can pull all the info together into a single file, rather than repeating and/or linking back to it.
Edit: Accidentally hit close.
fanquake closed this on Nov 25, 2017fanquake reopened this on Nov 25, 2017Sjors commented at 8:56 AM on November 26, 2017: memberMy initial idea was to make it a quick introduction to the code in this directory with pointers to more detailed information.
Given that QT is almost a standalone application, it could make sense to instead move all QT documentation to one place. In that case, would https://github.com/bitcoin-core/docs be more appropriate?
Either way, I don't think it should be too detailed, because then it won't be kept up to date. It should just be enough for a new developer - familiar with MVC, but not with QT - to get a sense of how the QT app is organized. More detailed descriptions can be inside individual source code files.
Some documentation could be avoided by adding more directories and using more consistent file naming, but that's future work, I think. @fanquake the build instructions are currently separated per OS (Unix is the most detailed). They don't specify how to build bitcoin-qt only (without compiling tests). I could add that there, or I could add links to build instructions for specific parts of the application. Maybe there should be a common build instructions file (pointing to each OS-specific file), which lists the various config flags and explains how to build specific targets?
laanwj commented at 7:50 AM on November 28, 2017: memberI think the overview of files and directories is useful!
The building stuff I'd prefer to keep only in
docbecause it's different per platform, in some cases per compiler (if/when we add the MSVC build system).They don't specify how to build bitcoin-qt only (without compiling tests)
Please don't encourage to skip building the tests.
I'd generalize that to "how to build individual executables with the automake build system", it's not Qt specific, the same could be used to build e.g. only the tests.
[docs] initial QT documentation, move Qt Creator instructions c8edc2c3cbSjors force-pushed on Dec 19, 2017Sjors commented at 3:55 PM on December 19, 2017: memberI got rid of the build instructions, moved Qt Creator stuff over from OSX build and added a few hints.
I'll keep updating this PR as I wrap my head around all of QT's moving parts.
jb55 approvedjb55 commented at 6:50 PM on December 29, 2017: memberACK, useful overview for noobs like me! Subdirectory READMEs are a plus as well since GitHub renders them when browsing directories.
laanwj commented at 7:48 PM on February 8, 2018: memberLooks good to me now. ACK https://github.com/bitcoin/bitcoin/pull/11761/commits/c8edc2c3cb79a1ae15622059004981c70f3775d8 (after you remove the WIP tag)
Sjors renamed this:[WIP] [docs] initial QT documentation
[docs] initial QT documentation
on Feb 9, 2018laanwj merged this on Feb 9, 2018laanwj closed this on Feb 9, 2018laanwj referenced this in commit 89005ddad1 on Feb 9, 2018Sjors deleted the branch on Feb 9, 2018PastaPastaPasta referenced this in commit e1eb6c725a on Jul 17, 2020PastaPastaPasta referenced this in commit db50935489 on Jul 17, 2020DrahtBot locked this on Sep 8, 2021Labels
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 09:15 UTC
More mirrored repositories can be found on mirror.b10c.me