[tests] Rename functional tests #11774

pull ajtowns wants to merge 6 commits into bitcoin:master from ajtowns:rename_tests changing 84 files +92 −96
  1. ajtowns commented at 5:16 pm on November 27, 2017: member

    This PR changes the functional tests to have a consistent naming scheme:

    tests for individual RPC methods are named rpc_...
tests for interfaces (REST, ZMQ, RPC features) are named interface_...
tests that explicitly test the p2p interface are named p2p_...
tests for wallet features are named wallet_...
tests for mining features are named mining_...
tests for mempool behaviour are named mempool_...
tests for full features that aren't wallet/mining/mempool are named feature_...

    Rationale: it’s sometimes difficult for new contributors to know what’s already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what’s already covered at a glance.

  2. fanquake added the label Tests on Nov 27, 2017
  3. ajtowns renamed this:
    [tests] Rename functional tests
    [WIP] [tests] Rename functional tests
    on Nov 30, 2017
  4. ajtowns force-pushed on Nov 30, 2017
  5. ajtowns commented at 9:43 am on November 30, 2017: member

    Split into two PRs – changes in #11796 should be reviewed and merged first. This PR will just be the actual renaming, so is easy to automatically regenerate, and should be easy to review once the previous PR is merged. Have also split the renaming into multiple commits by test area, which I think makes it a bit easier to review, but happy to revert that if not.

    Marking as WIP until #11796 is actually merged, since I’m expecting this to require a bunch of rebases.

  6. ajtowns force-pushed on Nov 30, 2017
  7. ajtowns force-pushed on Dec 5, 2017
  8. ajtowns commented at 9:56 am on December 5, 2017: member
    Updated to match fixes in parent PR, rebased to current master to fix merge conflicts, added final commit doing away with EXPECTED_VIOLATION_COUNT (but still allowing tests to pass with a warning if there’s 10 or fewer violations)
  9. ajtowns force-pushed on Dec 7, 2017
  10. ajtowns force-pushed on Dec 7, 2017
  11. ajtowns force-pushed on Dec 11, 2017
  12. ajtowns force-pushed on Dec 13, 2017
  13. ajtowns force-pushed on Jan 3, 2018
  14. ajtowns force-pushed on Jan 7, 2018
  15. ajtowns force-pushed on Jan 11, 2018
  16. ajtowns force-pushed on Jan 12, 2018
  17. laanwj referenced this in commit 4db16ec827 on Jan 15, 2018
  18. ajtowns force-pushed on Jan 15, 2018
  19. MarcoFalke commented at 1:49 pm on January 15, 2018: member
    @ajtowns Is this still WIP?
  20. jnewbery commented at 2:34 pm on January 15, 2018: member
    Tested ACK: c3fd1259f14e513934f6b2eee1f7febe708d04c7
  21. ajtowns commented at 2:35 pm on January 15, 2018: member
    @MarcoFalke if it’s merged, I think github will decide that any other PRs that touch any of the renamed test cases have conflicts and can’t be automatically merged. I was going to put together a list of those PRs before removing the WIP tag, but it’s late now, so tomorrow.
  22. ajtowns commented at 10:32 am on January 16, 2018: member

    The following PRs have the 0.16.0 milestone and touch test cases:

    • #11904: M test/functional/multiwallet.py (merged while I was writing this comment…)
    • #12101: M test/functional/wallet-encryption.py
    • #12119: M test/functional/address_types.py

    I think github will decide there’s conflicts and a rebase is required in whichever of these PRs get merged later (ie if 12119, 12101 or 11904 is merged first, github will claim this PR has conflicts; if this one is merged first, github will claim those PRs have conflicts).

    There’s a few PRs marked 0.17.0 or Future with the same issue along with some PRs that already have merge conflicts according to github. That leaves the following PRs that will likely “conflict” with this PR, that don’t have a milestone and are currently mergeable:

    • #10160 Add updatepeer RPC (jnewbery)
    • #10267 New -includeconf argument for including external configuration files (kallewoof)
    • #10367 [test] Test abortrescan command. (kallewoof)
    • #10386 [wallet] Optional ‘-avoidreuse’ flag which defaults to not reusing addresses in sends (kallewoof)
    • #10554 ZMQ: add publishers for wallet transactions. (somdoron)
    • #10595 Bugfix: RPC/Mining: Use pre-segwit sigops and limits, when working with non-segwit GBT clients (luke-jr)
    • #10757 RPC: Introduce getblockstats to plot things (jtimon)
    • #10877 [rpc] Verbose flags for chaining and scripting (kallewoof)
    • #10984 Allow 2 simultaneous (compact-)block downloads (TheBlueMatt)
    • #11120 [RPC] verifytxoutproof returns object including blockhash (instagibbs)
    • #11256 RPC: add weight to mempool entry output (esotericnonsense)
    • #11413 [wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option (kallewoof)
    • #11765 [REST] added blockhash api, tests and documentation (aaron-hanson)
    • #11771 [tests] Change invalidtxrequest to use BitcoinTestFramework (jnewbery)
    • #11772 [tests] Change invalidblockrequest to use BitcoinTestFramework (jnewbery)
    • #11773 [tests] Change p2p-fullblocktest to use BitcoinTestFramework (jnewbery)
    • #11817 [tests] Change bip68-112-113-p2p to use BitcoinTestFramework (jnewbery)
    • #11858 qa: Prepare tests for Windows (laanwj, MarcoFalke) (MarcoFalke)
    • #11869 QA: segwit.py: s/find_unspent/find_spendable_utxo/ (jtimon)
    • #11872 [rpc] createrawtransaction: Accept sorted outputs (MarcoFalke)
    • #12040 fix: add support for CORS headers and pre-flight request (lionello)
    • #12083 Improve getchaintxstats test coverage (promag)
    • #12089 qa: Make TestNodeCLI command optional in send_cli (MarcoFalke)
    • #12096 [rpc] [wallet] Allow specifying the output index when using bumpfee (kallewoof)
    • #12134 Build previous releases and run functional tests (Sjors)
    • #12136 Implement BIP 174 Partially Signed Bitcoin Transactions (achow101)
    • #12138 Track best-possible-headers (TheBlueMatt)
    • #12146 Wallet: Support disabling implicit Segwit operation (luke-jr)
    • #12172 Bugfix: RPC: savemempool: Don’t save until LoadMempool() is finished (jtimon)
    • #12196 Add scantxoutset RPC method (jonasschnelli)
  23. MarcoFalke commented at 0:40 am on January 17, 2018: member
    I think it makes sense to merge this into the 0.16 branch, so it is easier to switch back and forth between last release and master and have the same name for tests. I’d propose to wait for the merge of #12101 and #12119, then rebase on master and merge.
  24. ajtowns force-pushed on Jan 23, 2018
  25. ajtowns commented at 7:09 am on January 23, 2018: member
    Rebased. Will still conflict with #12213 (which already needs a rebase) and #12119 so either this will need to be updated after they’re merged, or they will need updating after this is merged.
  26. ajtowns renamed this:
    [WIP] [tests] Rename functional tests
    [tests] Rename functional tests
    on Jan 23, 2018
  27. jnewbery commented at 4:17 pm on January 23, 2018: member

    This should have a 0.16 milestone.

    I think it’s also fine to merge before #12213 and #12119 since both of those have review comments or rebasing to do anyway.

  28. promag commented at 4:30 pm on January 23, 2018: member
    The sooner the better, IMO even if they were ready…
  29. MarcoFalke commented at 6:07 pm on January 23, 2018: member

    ACK, but didn’t review the last commit.

     0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA512
 2
 3utACK e84b6e4ecda45b0b3c28bb71974f788f6fe95a5f
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQIcBAEBCgAGBQJaZ3nDAAoJENLqSFDnUoslSNkP/RJZGtQXmcF1kMkI+LtybqQU
 7Fm2hJoPP0ajEb0JQMtkHWGwqtMwXleFIAiuHWYdAhcFAxiWvHmtAU3nLE1WIC7Sf
 8m/3T7JuOfPR38FwA8TLW+nJZnjcoOAWILlgVpYc3Z0fFibS5bNNeXcd8W8GhXsrs
 9nF55VIQbgwvXk1cP0Blg0OdZkHfVr6j4ISTDxYWiEk0GRo7Uxti9LF/NvwIsQSbI
10bnLAOoKJu8TsD3bGg4gkhxI8C4FNn7BMPQPsqW5b9K+u8kk7ANwMlti7bW9ThSdd
11BZd4k/BqFrKIIfr6g/sLYob5vCPWC6xQgeStTNmdw1TdunH+eX6ystHw7r67PODD
12xFU/WwPbdu3PqLkUfly5ylI6tu5Rk6M0LEYXfihUIcadmbZSdqRPtnAo9xyUl7pi
13DzC/hZ3uCwTMoCYTm1geLXOgJFgyurrffCdFSncAf8a3aboSdXXwTMXvPrMVE/N7
14M54Fj5m6xH9LgybhKBAmCBjWIafjOAoc6TFcxr0bTj1ecuEjjtNEBYBEnp5qe+UV
15cIawWT86gQDukOPdK8Q7EgZvL43oDp1+SLvuGn+TgqJmkdxK3jJD1QGYgVFE5WHC
16sBbXLxOxclEkv0xV2ajNYi68H9IllNzLCMPBRCRD5fXehwoUTOV53KinrCiETp3I
17lo5tl7JBFO+I6wuGY6Me
18=Jp7/
19-----END PGP SIGNATURE-----
  30. in test/functional/test_runner.py:479 in e84b6e4ecd outdated 
    476+    """Check that at most a handful of the
477        test scripts don't start with one of the allowed name prefixes."""
478-    EXPECTED_VIOLATION_COUNT = 77
479 
480     # LEEWAY is provided as a transition measure, so that pull-requests
481     # that introduce new tests that don't conform with the naming
    MarcoFalke commented at 6:10 pm on January 23, 2018:

    Might as well set LEEWAY to 0, as I don’t see a need for this.

    After all, we want travis to fail if some test is named inproperly. Otherwise, it would lead to unnecessary fixup pull requests.

    ajtowns commented at 9:04 pm on January 23, 2018:

    Hmm, you might be right – no specific example comes to mind, but I’m still a bit hesistant about removing LEEWAY prior to 0.16 branching from master.

    I’ve put a commit that drops LEEWAY in #12252 ; assuming you definitely want it and Travis is happy with it, can merge it into this PR; otherwise can just merge #12252 when 0.16 branches off?

  31. MarcoFalke commented at 2:33 pm on January 24, 2018: member
    @ajtowns Needs rebase
  32. [tests] Rename feature_* functional tests. ca6523d0c8
  33. [tests] Rename wallet_* functional tests. 90600bc7db
  34. [tests] Rename p2p_* functional tests. 61b8f7f273
  35. [tests] Rename rpc_* functional tests. 81b79f2c39
  36. [tests] Rename misc functional tests. 3150b3fea7
  37. [tests] Remove EXPECTED_VIOLATION_COUNT 6f881cc880
  38. ajtowns force-pushed on Jan 25, 2018
  39. ajtowns commented at 0:12 am on January 25, 2018: member
    Rebased
  40. MarcoFalke commented at 1:42 am on January 25, 2018: member 
     0-----BEGIN PGP SIGNED MESSAGE-----
 1Hash: SHA512
 2
 3re-ACK 6f881cc8809e2c0d0150c47494bc37f2eb05ec66
 4-----BEGIN PGP SIGNATURE-----
 5
 6iQIcBAEBCgAGBQJaaTX3AAoJENLqSFDnUoslH1YQAJBMhrBIoF0AMKMW3lQN+h6U
 7mfv6jh7DZwWVLTkF2X98LUn3FHgPsDXDSAJtvfp3j4WYuWVeUryBqYR9P1WpWcMg
 8PYKgm/7NELtgImzpQ2FK3f/l5qCooZmjdNLG7y/JK2WUMJxZfLa8Z3nSmBQZipFf
 9zN41t7s2aXaeTM4pD2cZ6vS5cnzSXQMN3WrUYakEnMG36Jf74hB2l0aOGAIlZixa
10EMVzlult9sqVFyu3i5LzjLyU5MMy1mnQtH+cCjB0ScVTntcMMQhReLMvj1Uofa3z
119n+CO2B80CMZe+n7if4aW6bNPJbZw0aFjZ94nfOvwm3FHO8EZVZGVk1z/mOQIa1O
12vmlAtFaD0N5pp4d0zjhPKcKGi4gs6G3beXo5p5/W9icbEMVBYhutroqxEO/Y6K9x
13qIE9ZP2KhIiQLfogPP+RrkfOWWu6RwbIwf7pE1WLyGPAsFUBczmZvH/2tE1yhnUf
14a9Pr+cOfeWkQAFXbftH0F750r/be/xKjhn56q1a6VG4QNcCUN0FSjRFLPrRn+1cD
15Qxhl3Rnb/aKichY4kUnitvhfgALTkbFDKf5Brmh5seaif5qR+ujOewasGBc9We5s
16YLDu/nyPuXcf5malXBudG5RL7Yuti/e1Y3vcGai4OTPniIg6d/9L880BJOgKJTsf
17FnjxzQTjI02UBpO5VHFR
18=XBcp
19-----END PGP SIGNATURE-----
  41. MarcoFalke merged this on Jan 25, 2018
  42. MarcoFalke closed this on Jan 25, 2018
  43. MarcoFalke referenced this in commit 6970b30c6f on Jan 25, 2018
  44. jnewbery commented at 12:34 pm on January 25, 2018: member
    Thanks for maintaining this PR @ajtowns . You’re a patienter man than I!
  45. MarcoFalke referenced this in commit 8d57319863 on Jan 30, 2018
  46. laanwj referenced this in commit 5ad320598f on Feb 6, 2018
  47. PastaPastaPasta referenced this in commit a8951f0183 on Apr 13, 2020
  48. PastaPastaPasta referenced this in commit 1e94ccd694 on Apr 13, 2020
  49. PastaPastaPasta referenced this in commit 3e00841782 on Apr 13, 2020
  50. PastaPastaPasta referenced this in commit b23c766cc9 on Apr 13, 2020
  51. PastaPastaPasta referenced this in commit 17b61da1d5 on Jul 16, 2020
  52. PastaPastaPasta referenced this in commit 5bbeb9e3e4 on Jul 16, 2020
  53. UdjinM6 referenced this in commit b07a7b810c on Jul 16, 2020
  54. PastaPastaPasta referenced this in commit 4f77eff89c on Dec 16, 2020
  55. PastaPastaPasta referenced this in commit aae3da8cd3 on Dec 18, 2020
  56. theStack referenced this in commit de522a0114 on Aug 15, 2021
  57. DrahtBot locked this on Sep 8, 2021


ajtowns MarcoFalke jnewbery promag

Labels
Tests

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me