Replaces #10225 as it caused intermittent failures for some users.
Difference: gave up on making a "fast running" test and upped the blockchain size and spam count to avoid the scan finishing before the abort call. Moved test down to extended tests.
Test runs in roughly 2 minutes on my local machine. The blockchain generation part takes roughly 1m20s. @jnewbery Does this work on your end?
Still flakey for me:
→ ./test_runner.py
WARNING! The following scripts are not being run: ['p2p-fullblocktest.py', 'mempool_spendcoinbase.py', 'fundrawtransaction.py', 'mempool_resurrect_test.py', 'net.py', 'import-rescan.py', 'disconnect_ban.py', 'zapwallettxes.py', 'mempool_limit.py', 'multi_rpc.py', 'preciousblock.py', 'rawtransactions.py', 'importmulti.py', 'blockchain.py', 'bip68-112-113-p2p.py', 'httpbasics.py', 'listsinceblock.py', 'disablewallet.py', 'prioritise_transaction.py', 'invalidtxrequest.py', 'receivedby.py', 'importprunedfunds.py', 'listtransactions.py', 'wallet.py', 'p2p-compactblocks.py', 'wallet-accounts.py', 'signrawtransactions.py', 'nodehandling.py', 'p2p-segwit.py', 'nulldummy.py', 'keypool.py', 'signmessages.py', 'p2p-leaktests.py', 'wallet-hd.py', 'segwit.py', 'merkle_blocks.py', 'reindex.py', 'bumpfee.py', 'mempool_persist.py', 'wallet-dump.py', 'rest.py', 'invalidblockrequest.py', 'getchaintips.py', 'sendheaders.py', 'rpcnamedargs.py', 'proxy_test.py', 'decodescript.py', 'p2p-mempool.py', 'zmq_test.py', 'mempool_reorg.py', 'walletbackup.py', 'maxblocksinflight.py', 'p2p-versionbits-warning.py', 'abandonconflict.py']. Check the test lists in test_runner.py.
...........................................................
import-abort-rescan.py --portseed=3 passed, Duration: 30 s
......
import-abort-rescan.py --portseed=2 failed, Duration: 33 s
stdout:
2017-05-15 18:41:26.479000 TestFramework (INFO): Initializing test directory /tmp/user/1000/test3cj9jwid/166
2017-05-15 18:41:31.202000 TestFramework (INFO): Creating blocks with transactions ...
2017-05-15 18:41:50.352000 TestFramework (INFO): Sending to shared address ...
2017-05-15 18:41:50.422000 TestFramework (INFO): Importing address in background thread ...
2017-05-15 18:41:50.423000 TestFramework (INFO): Attempting to abort scan ...
2017-05-15 18:41:50.437000 TestFramework (INFO): Waiting for import thread to die ...
2017-05-15 18:41:50.538000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/ubuntu/bitcoin/test/functional/test_framework/test_framework.py", line 148, in main
self.run_test()
File "/home/ubuntu/bitcoin/test/functional/import-abort-rescan.py", line 62, in run_test
assert_equal(self.nodes[1].getbalance(), balances[1])
File "/home/ubuntu/bitcoin/test/functional/test_framework/util.py", line 408, in assert_equal
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
AssertionError: not(2475.12300000 == 2475.00000000)
2017-05-15 18:41:50.539000 TestFramework (INFO): Stopping nodes
2017-05-15 18:41:59.604000 TestFramework (WARNING): Not cleaning up dir /tmp/user/1000/test3cj9jwid/166
2017-05-15 18:41:59.604000 TestFramework (ERROR): Test failed. Test logging available at /tmp/user/1000/test3cj9jwid/166/test_framework.log
stderr:
..........
import-abort-rescan.py --portseed=1 failed, Duration: 39 s
stdout:
2017-05-15 18:41:26.476000 TestFramework (INFO): Initializing test directory /tmp/user/1000/test89_pqhmk/167
2017-05-15 18:41:31.503000 TestFramework (INFO): Creating blocks with transactions ...
2017-05-15 18:41:50.205000 TestFramework (INFO): Sending to shared address ...
2017-05-15 18:41:50.333000 TestFramework (INFO): Importing address in background thread ...
2017-05-15 18:41:50.334000 TestFramework (INFO): Attempting to abort scan ...
2017-05-15 18:41:54.919000 TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
File "/home/ubuntu/bitcoin/test/functional/test_framework/test_framework.py", line 148, in main
self.run_test()
File "/home/ubuntu/bitcoin/test/functional/import-abort-rescan.py", line 52, in run_test
assert abortres # if false, we failed to abort
AssertionError
2017-05-15 18:41:54.919000 TestFramework (INFO): Stopping nodes
2017-05-15 18:42:05.038000 TestFramework (WARNING): Not cleaning up dir /tmp/user/1000/test89_pqhmk/167
2017-05-15 18:42:05.038000 TestFramework (ERROR): Test failed. Test logging available at /tmp/user/1000/test89_pqhmk/167/test_framework.log
stderr:
Try running in parallel with pruning.py to reproduce this.
@jnewbery Sorry for taking so long. Assuming there is a race condition where your side ends up scanning the chain before the abort makes it through, this should definitely fix it, I think. The tests take ~4 mins on my machine, but they're already in extended tests. If this still shows intermittent failures on your end, I will need to go back to the drawing board, as it has to be something other than the above.
This may be specific to my local environment, but if I try to run this test multiple times in parallel, I get failures:
→ ./test_runner.py $(for i in {1..40}; do echo -n 'import-abort-rescan '; done)
Temporary test directory at /tmp/user/1000/bitcoin_test_runner_20170814_134812
WARNING! The following scripts are not being run: ['test_bitcoincli.py', 'bip65-cltv.py', 'wallet-labels.py', 'p2p-fullblocktest2.py', 'bitcoin_cli.py', 'keypool-topup.py', 'wallet-hd-restore.py', 'disablehot.py', 'blocknotify.py', 'getblocktemplate_proposals.py', 'resendwallettransactions.py', 'minchainwork.py', 'walletnotify.py', 'bipdersig.py', 'datalogging.py']. Check the test lists in test_runner.py.
.......................................................................................................................................................................................
import-abort-rescan.py failed, Duration: 97 s
stdout:
2017-08-14 13:48:33.367000 TestFramework (INFO): Initializing test directory /tmp/user/1000/bitcoin_test_runner_20170814_134812/import-abort-rescan_118
2017-08-14 13:48:38.719000 TestFramework (INFO): Creating blocks with transactions ...
2017-08-14 13:48:38.720000 TestFramework (INFO): ... 0%
2017-08-14 13:49:10.376000 TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
File "/home/ubuntu/bitcoin/test/functional/test_framework/authproxy.py", line 169, in _get_response
http_response = self.__conn.getresponse()
File "/usr/lib/python3.5/http/client.py", line 1197, in getresponse
response.begin()
File "/usr/lib/python3.5/http/client.py", line 297, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.5/http/client.py", line 258, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/lib/python3.5/socket.py", line 575, in readinto
return self._sock.recv_into(b)
socket.timeout: timed out
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/ubuntu/bitcoin/test/functional/test_framework/test_framework.py", line 149, in main
self.run_test()
File "/home/ubuntu/bitcoin/test/functional/import-abort-rescan.py", line 32, in run_test
self.nodes[0].sendtoaddress(addr, 0.1)
File "/home/ubuntu/bitcoin/test/functional/test_framework/coverage.py", line 46, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/home/ubuntu/bitcoin/test/functional/test_framework/authproxy.py", line 152, in __call__
response = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/home/ubuntu/bitcoin/test/functional/test_framework/authproxy.py", line 126, in _request
return self._get_response()
File "/home/ubuntu/bitcoin/test/functional/test_framework/authproxy.py", line 176, in _get_response
self.__conn.timeout)})
test_framework.authproxy.JSONRPCException: 'sendtoaddress' RPC took longer than 30.000000 seconds. Consider using larger timeout for calls that take longer to return. (-344)
2017-08-14 13:49:10.377000 TestFramework (INFO): Stopping nodes
2017-08-14 13:49:10.377000 TestFramework (ERROR): Unable to stop node
Traceback (most recent call last):
File "/home/ubuntu/bitcoin/test/functional/test_framework/test_framework.py", line 254, in stop_node
self.nodes[i].stop()
File "/home/ubuntu/bitcoin/test/functional/test_framework/coverage.py", line 46, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/home/ubuntu/bitcoin/test/functional/test_framework/authproxy.py", line 152, in __call__
response = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/home/ubuntu/bitcoin/test/functional/test_framework/authproxy.py", line 125, in _request
self.__conn.request(method, path, postdata, headers)
File "/usr/lib/python3.5/http/client.py", line 1106, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python3.5/http/client.py", line 1141, in _send_request
self.putrequest(method, url, **skips)
File "/usr/lib/python3.5/http/client.py", line 974, in putrequest
raise CannotSendRequest(self.__state)
http.client.CannotSendRequest: Request-sent
I'm running this in an ubuntu VM with quite slow spinning disk i/o.
@kallewoof - if you run ./test_runner.py $(for i in {1..40}; do echo -n 'import-abort-rescan '; done) do you get all success?
Just fyi
./test_runner.py $(for i in {1..40}; do echo -n 'import-abort-rescan '; done)
is passing for me on an ssd.
Thanks @MarcoFalke - probably caused by my slow disk in that case.
Yeah. Though, I think tests should run and pass on all platforms that are capable of running Bitcoin Core.
9 | +2. Subsequent rescan catches the aborted address UTXO 10 | +""" 11 | + 12 | +from test_framework.test_framework import BitcoinTestFramework 13 | +from test_framework.util import (assert_equal, get_rpc_proxy) 14 | +from decimal import Decimal
nit: prefer imports to be in PEP-8 ordering (standard libraries first)
I put decimal, threading, and time imports at top.
14 | +from decimal import Decimal 15 | +import threading # for bg importprivkey 16 | +import time # for sleep 17 | + 18 | +class ImportAbortRescanTest(BitcoinTestFramework): 19 | + def __init__(self):
No need to override method if you're just calling into super()
24 | + # Generate for BTC 25 | + self.nodes[0].generate(300) 26 | + self.log.info("Creating blocks with transactions ...") 27 | + # Make blocks with spam to cause rescan delay 28 | + for i in range(200): 29 | + if i % 50 == 0: self.log.info("... %2.f%%", 100.0 / 200.0 * i)
nit: if block should appear on the next line. Same for the if xxxxx: break lines below
57 | + for i in range(10): 58 | + time.sleep(0.1) 59 | + deadres = not importthread.isAlive() 60 | + if deadres: break 61 | + 62 | + assert deadres # if false, importthread did not die soon enough
nit: prefer assert deadres, "importthread did not die soon enough" (so the error message is delivered to the user)
Nice.. I didn't know you could do that.
A few nits.
This still seems flakey for me, so should get some wider testing before being merged.
13 | +import threading # for bg importprivkey 14 | +import time # for sleep 15 | +from test_framework.test_framework import BitcoinTestFramework 16 | +from test_framework.util import (assert_equal, get_rpc_proxy) 17 | + 18 | +class ImportAbortRescanTest(BitcoinTestFramework):
It seems you are not specifying the constructor (__init__). Thus 2 additional nodes are spun up and remain unused.
Good point. Fixed.
socket.timeout: timed out probably means that running this test 4 times in parallel is too much for my VM, and one of the rpc calls timed out.
51 | + for i in range(2000): 52 | + time.sleep(0.001) 53 | + abortres = self.nodes[1].abortrescan() 54 | + if abortres: 55 | + break 56 | + assert abortres # if false, we failed to abort
nit: could change this to:
assert abortres, "abortrescan call failed"
Fixed, thanks!
One small nit, but otherwise looks good.
Please squash your commits if this is no longer WIP
@MarcoFalke Squashed & removed '[WIP]' from title.
14 | +import time # for sleep 15 | +from test_framework.test_framework import BitcoinTestFramework 16 | +from test_framework.util import (assert_equal, get_rpc_proxy) 17 | + 18 | +class ImportAbortRescanTest(BitcoinTestFramework): 19 | + def __init__(self):
Replace with
def set_test_params(self):
self.num_nodes = 2
9 | +2. Subsequent rescan catches the aborted address UTXO 10 | +""" 11 | + 12 | +from decimal import Decimal 13 | +import threading # for bg importprivkey 14 | +import time # for sleep
Change and remove comment:
from time import sleep
The same above.
0 | @@ -0,0 +1,75 @@ 1 | +#!/usr/bin/env python3 2 | +# Copyright (c) 2017 The Bitcoin Core developers 3 | +# Distributed under the MIT software license, see the accompanying 4 | +# file COPYING or http://www.opensource.org/licenses/mit-license.php. 5 | +"""Test wallet import RPCs. 6 | + 7 | +Test rescan behavior of importprivkey when aborted. The test ensures that: 8 | +1. The abortrescan command indeed stops the rescan process. 9 | +2. Subsequent rescan catches the aborted address UTXO
Nit, missing period.
0 | @@ -0,0 +1,75 @@ 1 | +#!/usr/bin/env python3 2 | +# Copyright (c) 2017 The Bitcoin Core developers 3 | +# Distributed under the MIT software license, see the accompanying 4 | +# file COPYING or http://www.opensource.org/licenses/mit-license.php. 5 | +"""Test wallet import RPCs. 6 | + 7 | +Test rescan behavior of importprivkey when aborted. The test ensures that: 8 | +1. The abortrescan command indeed stops the rescan process.
Nit, use unordered, ie, - The abortrescan ... .
I'm not sure what the reason for this is. It is easier to refer to a point by number, e.g. "this test is no longer checking the 3rd point mentioned in the comment".
21 | + self.num_nodes = 2 22 | + 23 | + def run_test(self): 24 | + # Generate for BTC 25 | + self.nodes[0].generate(300) 26 | + self.log.info("Creating blocks with transactions ...")
I don't think it makes sense to move code up into the test_framework directory unless it's being used by more than one test script. I don't see the need here (unless you think you can refactor other test scripts to use this and reduce LOC)
Would it make sense to take advantage of mine_large_block or is that overkill in this context? Might make this test more concise.
Missing test for when abortrescan returns false.
9 | +2. Subsequent rescan catches the aborted address UTXO. 10 | +""" 11 | + 12 | +from decimal import Decimal 13 | +import threading # for bg importprivkey 14 | +import sleep from time
invalid syntax. Should be from time import sleep
I was able to get most of the tests to pass running in parallel on the following:
Ubuntu 16.04.2 LTS x86_64 1 Core 2.50GHz CPU 1GB RAM HDD
Debian GNU/Linux 8.9 x86_64 1 Core 2.80 GHz CPU 2GB RAM HDD
MacOS High Sierra x86_64 2 Cores 3.3 GHz CPU 16GB RAM SSD 39/40 tests passed successfully
Error:
stdout:
2017-12-09 22:59:54.102000 TestFramework (INFO): Initializing test directory /var/folders/db/5xcqh4b57l7380mcv8c0kj8r0000gn/T/bitcoin_test_runner_20171209_170923/import-abort-rescan_85
2017-12-09 23:00:20.768000 TestFramework (INFO): Creating blocks with transactions ...
2017-12-09 23:00:20.782000 TestFramework (INFO): ... 0%
2017-12-09 23:02:37.124000 TestFramework (INFO): ... 25%
2017-12-09 23:04:59.728000 TestFramework (INFO): ... 50%
2017-12-09 23:07:31.909000 TestFramework (INFO): ... 75%
2017-12-09 23:10:03.214000 TestFramework (INFO): Sending to shared address ...
2017-12-09 23:10:04.581000 TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
File "/bitcoin/test/functional/test_framework/test_framework.py", line 120, in main
self.run_test()
File "/bitcoin/test/functional/import-abort-rescan.py", line 40, in run_test
self.sync_all()
File "/bitcoin/test/functional/test_framework/test_framework.py", line 328, in sync_all
sync_blocks(group)
File "/bitcoin/test/functional/test_framework/util.py", line 368, in sync_blocks
maxheight = max(x.getblockcount() for x in rpc_connections)
File "/bitcoin/test/functional/test_framework/util.py", line 368, in <genexpr>
maxheight = max(x.getblockcount() for x in rpc_connections)
File "/bitcoin/test/functional/test_framework/coverage.py", line 47, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/bitcoin/test/functional/test_framework/authproxy.py", line 136, in __call__
response = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/bitcoin/test/functional/test_framework/authproxy.py", line 106, in _request
self.__conn.request(method, path, postdata, headers)
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1239, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1285, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1234, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1065, in _send_output
self.send(chunk)
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 986, in send
self.sock.sendall(data)
OSError: [Errno 41] Protocol wrong type for socket
2017-12-09 23:10:04.605000 TestFramework (INFO): Stopping nodes
2017-12-09 23:10:04.623000 TestFramework.node1 (ERROR): Unable to stop node.
Traceback (most recent call last):
File "/bitcoin/test/functional/test_framework/test_node.py", line 125, in stop_node
self.stop()
File "/bitcoin/test/functional/test_framework/coverage.py", line 47, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/bitcoin/test/functional/test_framework/authproxy.py", line 136, in __call__
response = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/bitcoin/test/functional/test_framework/authproxy.py", line 106, in _request
self.__conn.request(method, path, postdata, headers)
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1239, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1250, in _send_request
self.putrequest(method, url, **skips)
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1108, in putrequest
raise CannotSendRequest(self.__state)
http.client.CannotSendRequest: Request-sent
stderr:
Traceback (most recent call last):
File "/bitcoin/test/functional/import-abort-rescan.py", line 77, in <module>
ImportAbortRescanTest().main()
File "/bitcoin/test/functional/test_framework/test_framework.py", line 143, in main
self.stop_nodes()
File "/bitcoin/test/functional/test_framework/test_framework.py", line 277, in stop_nodes
node.wait_until_stopped()
File "/bitcoin/test/functional/test_framework/test_node.py", line 151, in wait_until_stopped
wait_until(self.is_node_stopped, timeout=timeout)
File "/bitcoin/test/functional/test_framework/util.py", line 222, in wait_until
assert_greater_than(timeout, time.time())
File "/bitcoin/test/functional/test_framework/util.py", line 42, in assert_greater_than
raise AssertionError("%s <= %s" % (str(thing1), str(thing2)))
AssertionError: 1512861065.40589 <= 1512861065.4063418
@maxgiraldo Thanks for testing! I tried on same mac set up (except more cores) doing
./test_runner.py $(for i in {1..40}; do echo -n 'import-abort-rescan '; done)
and it is working on my end. What command are you using to run the tests?
@kallewoof No problem! I'm using ./test_runner.py $(for i in {1..40}; do echo -n 'import-abort-rescan '; done) as well. I ran the tests again on Mac about three more times and got the same error, but only on the last run.
@maxgiraldo After running it for a long time I managed to reproduce. Looking into it now.
Hum. I can't reproduce this without running for hours. It feels like something is being exhausted, triggering the issue, but even after running for several hours I don't see any spikes in resource usage and drive has 100 GB free. @jnewbery any thoughts on why "OSError: [Errno 41] Protocol wrong type for socket" would happen occasionally for
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
(test_framework/coverage.py#46)?
@kallewoof Seems to be a MacOS/OS X-specific kernel issue, which throws the error code EPROTOTYPE when you attempt to do a TCP send syscall while a socket is not yet connected or is in the process of being torn down.*
Hmmm, I've definitely read that blog post before, but I can't remember what exactly the context was! @maxgiraldo - perhaps you could add additional exception handling here: https://github.com/bitcoin/bitcoin/blob/d4991c0cbb8a5464add1b64268eccdbfd3026d6e/test/functional/test_framework/authproxy.py#L108
Something like:
except OSError as e:
if e.errno == 42:
# EPROTOTYPE - OS X issue: a TCP send syscall while a socket is
# not yet connected or is in the process of being torn down.
self.__conn.close()
self.__conn.request(method, path, postdata, headers)
return self._get_response()
else:
raise
You could add a print statement or pdb breakpoint in there to confirm that you can reproduce and that this fixes this:
except OSError as e:
if e.errno == 42:
# EPROTOTYPE - OS X issue: a TCP send syscall while a socket is
import pdb; pbd.set_trace()
Do you think this error is specific to this new test, or are you able to reproduce it on other tests? If it's not specific to this test, perhaps you can open a new issue or PR to track it.
I can reproduce as well, but it sometimes takes hours. Will try your patch in a couple hours on my end. I'll push a commit so @maxgiraldo can test it too if he hasn't tried it manually already.
Different error now. Something very weird is going on with networking here.
2017-12-18 03:53:15.458000 TestFramework (INFO): Initializing test directory /var/folders/b8/znqr8hj918772gfmd875gzgdd3ypz1/T/bitcoin_test_runner_20171218_125257/import-abort-rescan_635
2017-12-18 03:53:21.588000 TestFramework (INFO): Creating blocks with transactions ...
2017-12-18 03:53:21.592000 TestFramework (INFO): ... 0%
2017-12-18 03:54:49.215000 TestFramework (INFO): ... 25%
2017-12-18 03:56:23.323000 TestFramework (INFO): ... 50%
2017-12-18 03:57:56.488000 TestFramework (INFO): ... 75%
2017-12-18 03:59:29.920000 TestFramework (INFO): Sending to shared address ...
2017-12-18 03:59:30.218000 TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
File "<dir>/bitcoin/test/functional/test_framework/test_framework.py", line 117, in main
self.run_test()
File "<dir>/bitcoin/test/functional/import-abort-rescan.py", line 39, in run_test
self.sync_all()
File "<dir>/bitcoin/test/functional/test_framework/test_framework.py", line 320, in sync_all
sync_blocks(group)
File "<dir>/bitcoin/test/functional/test_framework/util.py", line 350, in sync_blocks
maxheight = max(x.getblockcount() for x in rpc_connections)
File "<dir>/bitcoin/test/functional/test_framework/util.py", line 350, in <genexpr>
maxheight = max(x.getblockcount() for x in rpc_connections)
File "<dir>/bitcoin/test/functional/test_framework/coverage.py", line 46, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "<dir>/bitcoin/test/functional/test_framework/authproxy.py", line 162, in __call__
response = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "<dir>/bitcoin/test/functional/test_framework/authproxy.py", line 126, in _request
return self._get_response()
File "<dir>/bitcoin/test/functional/test_framework/authproxy.py", line 179, in _get_response
http_response = self.__conn.getresponse()
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1331, in getresponse
response.begin()
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 297, in begin
version, status, reason = self._read_status()
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 258, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
ConnectionResetError: [Errno 54] Connection reset by peer
2017-12-18 03:59:30.332000 TestFramework (INFO): Stopping nodes
2017-12-18 03:59:32.775000 TestFramework (WARNING): Not cleaning up dir /var/folders/b8/znqr8hj918772gfmd875gzgdd3ypz1/T/bitcoin_test_runner_20171218_125257/import-abort-rescan_635
2017-12-18 03:59:32.775000 TestFramework (ERROR): Test failed. Test logging available at /var/folders/b8/znqr8hj918772gfmd875gzgdd3ypz1/T/bitcoin_test_runner_20171218_125257/import-abort-rescan_635/test_framework.log
Pushed commit with fix in it. This still breaks on my end after running for awhile.
111 | @@ -112,6 +112,16 @@ def _request(self, method, path, postdata): 112 | return self._get_response() 113 | else: 114 | raise 115 | + except OSError as e: 116 | + if e.errno == 42:
The errno is actually 41; to avoid hardcoding the value, I would use from errno import EPROTOTYPE and then:
if e.errno == EPROTOTYPE:
...
Oops, good catch.
Connection reset by peer after a shortish while. Very curious.
2017-12-21 01:10:24.464000 TestFramework (INFO): Initializing test directory /var/folders/b8/znqr8hj918772gfmd875gzgdd3ypz1/T/bitcoin_test_runner_20171221_100356/import-abort-rescan_961
2017-12-21 01:10:40.349000 TestFramework (INFO): Creating blocks with transactions ...
2017-12-21 01:10:40.352000 TestFramework (INFO): ... 0%
2017-12-21 01:11:50.257000 TestFramework (INFO): ... 25%
2017-12-21 01:13:02.097000 TestFramework (INFO): ... 50%
2017-12-21 01:14:12.874000 TestFramework (INFO): ... 75%
2017-12-21 01:15:22.978000 TestFramework (INFO): Sending to shared address ...
2017-12-21 01:15:23.566000 TestFramework (ERROR): Unexpected exception caught during testing
Traceback (most recent call last):
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/test_framework/test_framework.py", line 118, in main
self.run_test()
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/import-abort-rescan.py", line 39, in run_test
self.sync_all()
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/test_framework/test_framework.py", line 313, in sync_all
sync_blocks(group)
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/test_framework/util.py", line 368, in sync_blocks
maxheight = max(x.getblockcount() for x in rpc_connections)
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/test_framework/util.py", line 368, in <genexpr>
maxheight = max(x.getblockcount() for x in rpc_connections)
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/test_framework/coverage.py", line 47, in __call__
return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/test_framework/authproxy.py", line 147, in __call__
response = self._request('POST', self.__url.path, postdata.encode('utf-8'))
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/test_framework/authproxy.py", line 108, in _request
return self._get_response()
File "/Users/karljohan-alm/workspace/bitcoin-kw/test/functional/test_framework/authproxy.py", line 164, in _get_response
http_response = self.__conn.getresponse()
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 1331, in getresponse
response.begin()
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 297, in begin
version, status, reason = self._read_status()
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/http/client.py", line 258, in _read_status
line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
File "/usr/local/Cellar/python3/3.6.3/Frameworks/Python.framework/Versions/3.6/lib/python3.6/socket.py", line 586, in readinto
return self._sock.recv_into(b)
ConnectionResetError: [Errno 54] Connection reset by peer
2017-12-21 01:15:23.570000 TestFramework (INFO): Stopping nodes
2017-12-21 01:15:24.265000 TestFramework (WARNING): Not cleaning up dir /var/folders/b8/znqr8hj918772gfmd875gzgdd3ypz1/T/bitcoin_test_runner_20171221_100356/import-abort-rescan_961
2017-12-21 01:15:24.269000 TestFramework (ERROR): Test failed. Test logging available at /var/folders/b8/znqr8hj918772gfmd875gzgdd3ypz1/T/bitcoin_test_runner_20171221_100356/import-abort-rescan_961/test_framework.log
2017-12-21 01:15:24.270000 TestFramework (ERROR): Hint: Call /Users/karljohan-alm/workspace/bitcoin-kw/test/functional/combine_logs.py '/var/folders/b8/znqr8hj918772gfmd875gzgdd3ypz1/T/bitcoin_test_runner_20171221_100356/import-abort-rescan_961' to consolidate all logs
Closing for now, as this PR seems to be dormant, let me know when you want to pick it up again and I'll reopen.