Bitcoin-Qt Coin Selection window has unnecessary columns "9" and "10" #11811

issue unsystemizer opened this issue on December 1, 2017

unsystemizer commented at 3:14 PM on December 1, 2017: contributor
Maybe they have some purpose, but it isn't immediately obvious. I tried Tree & List mode, they're never populated.
- Bitcoin-Qt 0.15.1 for Ubuntu 16.04 x64 (from http://ppa.launchpad.net/bitcoin/bitcoin/ubuntu xenial/main amd64)
Note: I just noticed I'm not seeing this on Ubuntu 17.10 x64 with 0.15.1 downloaded from bitcoincore.org.
MarcoFalke commented at 5:20 PM on December 1, 2017: member

In theory they are meant to be hidden.

https://github.com/bitcoin/bitcoin/blob/3c098a8aa0780009c11b66b1a5d488a928629ebf/src/qt/coincontroldialog.cpp#L131-L138
MarcoFalke added the label GUI on Dec 1, 2017
jonasschnelli commented at 6:46 AM on December 2, 2017: contributor

It's probably because the PPA is built with an older version then Qt5.7 which we use in depends. Could even be a Qt4 version. @TheBlueMatt: does it still uses Qt4?
unsystemizer commented at 5:40 PM on December 2, 2017: contributor

The PPA one is linked against libQtGui.so.4 while the build from Bitcoin Core Web site seems to be using v5.3.
TheBlueMatt commented at 9:32 PM on December 5, 2017: member

We (still) cant move off of Qt4 because of #9038. Still waiting on the death of the tray icon...
laanwj commented at 1:50 PM on December 6, 2017: member

FWIW it shouldn't be necessary to use columns to store extra per-row information, from what I remember there are other ways to store extra information in the model backing the tree widget, though I don't remember immediately how.

We (still) cant move off of Qt4 because of #9038. Still waiting on the death of the tray icon...

The death of ubuntu unity is probably sooner. I'm almost certain no other desktop environment has this problem.
jb55 commented at 6:13 PM on October 3, 2018: member

Is this still an issue?
jonasschnelli closed this on Dec 4, 2018
jonasschnelli referenced this in commit 64fc7c0c1b on Dec 4, 2018
UdjinM6 referenced this in commit 9f02792ee5 on Sep 13, 2020
xdustinface referenced this in commit b7bbbd1335 on Sep 16, 2020
xdustinface referenced this in commit c76a737730 on Sep 16, 2020
UdjinM6 referenced this in commit b10dc1f547 on Sep 23, 2020
PastaPastaPasta referenced this in commit f4e3bf95d0 on Sep 24, 2020
ckti referenced this in commit 3ed47f402c on Mar 28, 2021
DrahtBot locked this on Sep 8, 2021
gades referenced this in commit fdfbddb69b on Mar 5, 2022

Contributors

Labels

Linked (view graph)

#14817 qt: Remove unnecessary columns in Coin Selection window (#11811)#14828 qt: Remove hidden columns in coin control dialog