I accidentally [deliberately] killed it [the ComparisonTestFramework] #11818

1. 
   jnewbery commented at 4:30 pm on December 2, 2017: member

   Builds on #11772, #11773 and #11817. Please review those PRs first.

   Final step in #10603.

   • First commit removes bip9-softforks.py. bip9-sofforks.py was intended to be a generic test for versionbits deployments. However, it only tests CSV activation and was not updated to test segwit activation. CSV activation is tested by bip68-112-113-p2p.py, so this test is duplicated effort. Rather than try to update it to use the BitcoinTestFramework, just remove it. (see https://github.com/btcdrak/bitcoin/pull/8 for previous discussion around the redundancy of bip9-softforks.py)
   • Second commit removes the now unused BitcoinComparisonFramework class and the comptool and blockstore modules.
2. fanquake added the label Tests on Dec 2, 2017
3. jnewbery force-pushed on Dec 14, 2017
4. 
   ryanofsky commented at 9:27 pm on December 20, 2017: member

   Reviewed just the two removal commits, assuming all the other commits will go away when this is rebased.

   • utACK 5e483e1eae34083ebfe7bc89d21644fa2c8f4389 [tests] Remove Comparison Test Framework
   • utACK 8be729761f794d92b5bec2262ebee9fea35e518a [tests] Remove bip9-softforks.py
5. laanwj assigned MarcoFalke on Mar 6, 2018
6. jnewbery force-pushed on Mar 29, 2018
7. 
   jnewbery commented at 3:50 pm on March 29, 2018: member

   Rebased to remove merged commits.
8. [tests] Remove bip9-softforks.py

   bip9-sofforks.py was intended to be a generic test for versionbits
   deployments. However, it only tests CSV activation and was not updated
   to test segwit activation. CSV activation is tested by
   bip68-112-113-p2p.py, so this test is duplicated effort.
   
   Rather than try to update it to use the BitcoinTestFramework, just
   remove it.

   e80c640d78
9. jnewbery force-pushed on Apr 2, 2018
10. 
    jnewbery commented at 5:47 pm on April 2, 2018: member

    Rebased. This should be a very easy review, since it’s just removing dead code.
11. 
    sdaftuar commented at 5:53 pm on April 2, 2018: member

    utACK! Thanks for sticking with this.
12. [tests] Remove Comparison Test Framework 9c92c8c827
13. in test/functional/README.md:138 in 2382bca42b outdated

    133-    acceptance is tested against the given outcome.
    134-
    135-- For examples of tests written in this framework, see
    136-  `p2p_invalid_block.py` and `feature_block.py`.
    137-
    138-### test-framework modules
    

    ---

    ---

    

    MarcoFalke commented at 5:55 pm on April 2, 2018:

    nit: Is this line supposed to go away?

    ---

    

    jnewbery commented at 6:04 pm on April 2, 2018:

    Good spot! Added that back, and removed the documentation for test_framework/blockstore.py
14. jnewbery force-pushed on Apr 2, 2018
15. 
    MarcoFalke commented at 6:34 pm on April 2, 2018: member

    utACK 9c92c8c82716d0c35b638142a1125d07b3f240a8
16. MarcoFalke merged this on Apr 5, 2018
17. MarcoFalke closed this on Apr 5, 2018

    ---

18. MarcoFalke referenced this in commit 9a2db3b3d5 on Apr 5, 2018
19. jnewbery deleted the branch on Apr 5, 2018
20. codablock referenced this in commit c88a7b9e76 on Jan 14, 2020
21. random-zebra referenced this in commit db5e692613 on May 17, 2021
22. MarcoFalke locked this on Sep 8, 2021

Contributors
jnewbery ryanofsky sdaftuar MarcoFalke

Labels
Tests