We already require XP, this just fixes Mingw64 build.
Update to require IE 5.1 as it is required to build on mingw64. #1187
pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:win32_ie changing 1 files +1 −1-
TheBlueMatt commented at 12:23 AM on May 3, 2012: member
-
234db30d66
Update to require IE 5.1 as it is required on mingw64.
We already require XP, this just fixes Mingw64 build.
-
sipa commented at 1:33 AM on May 3, 2012: member
ACK
-
Diapolo commented at 5:24 AM on May 3, 2012: none
Perhaps that is a dumb question, but is that the minimum IE version that has to be installed on the client running the BC client or is it needed for the machine, which compiles the executable?
I'm asking, because I'm sure MS doesn't support IE 5.1 anymore and we should perhaps do the same then?
-
laanwj commented at 5:45 AM on May 3, 2012: member
ACK @diapolo Right, we don't actually use IE, but if you define _WIN32_IE to some old version you may be including some deprecated API that no longer exists on 64 bit windows.
Edit: which makes me wonder, what happens if you don't define _WIN32_IE at all? or do all windows programs need it? If so, why don't we define these things (_WIN32_WINNT, _WIN32_IE) centrally in the build system instead?
-
Diapolo commented at 7:28 AM on May 3, 2012: none
I will try to compile without and see what happens ... seems like it compiles with _WIN32_IE only and _WIN32_WINNT removed. Afaik it tells the compiler which WinAPI functions are available with the specified IE / WINNT version.
In util.cpp it is needed for SHGetSpecialFolderPathA() function.
- laanwj referenced this in commit 1f6f261ace on May 5, 2012
- laanwj merged this on May 5, 2012
- laanwj closed this on May 5, 2012
- coblee referenced this in commit f4bedc8715 on Jul 17, 2012
- suprnurd referenced this in commit 9f2d79d920 on Dec 5, 2017
- lateminer referenced this in commit 0a2baa686d on Dec 25, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors