Trivial: Spelling fix, python → Python #11920

pull comradekingu wants to merge 1 commits into bitcoin:master from comradekingu:patch-1 changing 3 files +3 −3

comradekingu commented at 7:02 AM on December 17, 2017: none

As per https://www.python.org
jonasschnelli commented at 7:06 AM on December 17, 2017: contributor

See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#refactoring IMO it's a distracting PR with no benefits.

in src/qt/bitcoinstrings.cpp:222 in d40e648710 outdated

 218 | @@ -219,7 +219,7 @@ QT_TRANSLATE_NOOP("bitcoin-core", ""
 219 |  "%s)"),
 220 |  QT_TRANSLATE_NOOP("bitcoin-core", ""
 221 |  "Username and hashed password for JSON-RPC connections. The field <userpw> "
 222 | -"comes in the format: <USERNAME>:<SALT>$<HASH>. A canonical python script is "

fanquake commented at 7:11 AM on December 17, 2017:

Don't modify this file, it is "Automatically generated by extract_strings_qt.py".

fanquake commented at 7:21 AM on December 17, 2017: member

Please squash your commits, and amend the commit message as per the contributing guidelines.
python → Python
python → Python python → Python
22bda7c56d
comradekingu force-pushed on Dec 17, 2017
comradekingu renamed this:
~~python → Python~~
Trivial: Spelling fix, python → Python
on Dec 17, 2017
laanwj commented at 10:01 AM on December 17, 2017: member

I appreciate that you're trying to contribute, and have nothing against this change in itself, however please don't submit PRs that just change words around. If you are looking for something worthwhile to address you could look at the open issues, for example the list of good first issues and pick something from there.
comradekingu commented at 10:20 AM on December 17, 2017: none

@laanwj However minuscule, this is a user facing string with ~~a bug~~ spelling error in it. Was trying to find out what the process is, for fixing some of the more unclear strings later.
promag commented at 11:14 AM on December 17, 2017: member

I wouldn't say bug, nothing is broken.
laanwj added the label Refactoring on Dec 17, 2017
laanwj commented at 11:19 AM on December 17, 2017: member

Don't use the word 'bug' like that, please. It's certainly possible to have a bug in a text message or documentation when it explains things wrong, and sometimes those are serious bugs that can result in coin loss. However, this is not one of such. You're welcome to improve messages if they're unclear, though!
comradekingu commented at 2:02 PM on December 17, 2017: none

@laanqj My apologies. Adjusting for clarity in strings other than this leaves a whole lot less room for misunderstandings, making for fewer errors in translation. I don't know what there is to be avoided, but I found some strings where the certainty of the outcome could be narrowed down quite a bit.
MarcoFalke commented at 2:42 PM on December 17, 2017: member

@comradekingu No need to apologise.

Tend to NACK, as this will invalidate all existing translations and we'd have to manually (or by script) fix them up on transifex. Imo, not worth it.
promag commented at 7:44 PM on December 17, 2017: member

Please drop unicode from PR title and commit message.
promag commented at 7:44 PM on December 17, 2017: member

Good point @MarcoFalke.
fanquake closed this on Dec 18, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels