logs: Improve "mempool min fee not met" error #11969

pull Varunram wants to merge 2 commits into bitcoin:master from Varunram:mempoolfix changing 2 files +3 −1

Varunram commented at 5:34 AM on December 21, 2017: contributor

Intended as a fix for #11955. I'm pretty new here, so apologies if this isn't the intended fix. Thanks!

logs: Improve "mempool min fee not met" error

Include the minimum mempool fee with the error message returned

c204de7dbc

laanwj added the label Mempool on Dec 21, 2017
laanwj commented at 8:44 AM on December 21, 2017: member

nFees, mempoolRejectFee is already in the extended description (strDebugMessageIn) - A broader fix would be to log/return that where it's reported, instead of changing the main message.
Varunram commented at 9:09 AM on December 21, 2017: contributor

Thanks, I'll do the changes and update the PR
Add log message in fees.cpp 644a693c72
in src/wallet/fees.cpp:63 in 644a693c72
```
  58 | @@ -59,6 +59,8 @@ CAmount GetMinimumFee(unsigned int nTxBytes, const CCoinControl& coin_control, c
  59 |          if (fee_needed < min_mempool_fee) {
  60 |              fee_needed = min_mempool_fee;
  61 |              if (feeCalc) feeCalc->reason = FeeReason::MEMPOOL_MIN;
  62 | +        } else {
  63 | +            LogPrintf("Minimum mempool fee(%d) not met", min_mempool_fee);
```
laanwj commented at 2:14 PM on December 21, 2017:

I don't think Get* is a good place to log a message.

What I meant is that in the current place where you see "mempool min fee not met" being logged with further information, it should log the debug message of the state too, as the information is already in there just apparently not exposed.

Varunram commented at 2:23 PM on December 21, 2017:

Thanks for the review, I'll do the changes.
fanquake commented at 1:35 PM on January 29, 2018: member

Closing for now. Please reopen when you've adjusted this PR.
fanquake closed this on Jan 29, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#11955 Improve "mempool min fee not met" error to include information on what the min fee is