Fix gitian build after libzmq bump #11981

1. 
   theuni commented at 11:04 pm on December 21, 2017: member

   Broken gitian builds were introduced with #9254. Big thanks to @jonasschnelli for narrowing down the bisection.

   This is broken for a number of reasons, including:

   • g++ understands “-static-libstdc++ -lstdc++” to mean “link against whatever libstdc++ exists, probably shared”, which in itself is buggy.
   • another stdlib (libc++ for example) may be in use
2. depends: fix libzmq's needless linking against libstdc++

   This is broken for a number of reasons, including:
   - g++ understands "-static-libstdc++ -lstdc++" to mean "link against whatever
     libstdc++ exists, probably shared", which in itself is buggy.
   - another stdlib (libc++ for example) may be in use

   a6365c5c3d
3. 
   jonasschnelli commented at 11:38 pm on December 21, 2017: contributor

   Let’s see Just started https://bitcoin.jonasschnelli.ch/build/431

   We should probably always test depends changes with a gitian build.

4. fanquake added the label Build system on Dec 22, 2017
5. 
   fanquake commented at 1:25 am on December 22, 2017: member

   I’m wondering, before we fix this, should we update to 4.2.3 and see if anything else breaks? It was only recently released, which is why it wasn’t in #9254, and basically includes a years worth of bug fixes, which I think would be good to get in.

   Note: We’d want to look at patching for OpenBSD: https://github.com/zeromq/libzmq/commit/22b57f6f2844ebe2d720a19315f5f3ad44c508ea

6. 
   theuni commented at 2:01 am on December 22, 2017: member

   Sure, though I checked upstream master before creating the patch here, in case there was something to backport (and also to file a bug report, which I haven’t done yet).

   So this fix should work with 4.2.3. as well.

   Re OpenBSD, we don’t currently build releases, so no need to worry about that patch.

7. 
   jonasschnelli commented at 6:33 am on December 22, 2017: contributor

   Fixed the gitian build (https://bitcoin.jonasschnelli.ch/build/431). Tested ACK a6365c5c3d277af355c51d7aee969f261dc5a751
8. 
   laanwj commented at 8:22 am on December 22, 2017: member

   This one is extremely sneaky. Why the hell would they do this? utACK https://github.com/bitcoin/bitcoin/pull/11981/commits/a6365c5c3d277af355c51d7aee969f261dc5a751

   Re OpenBSD, we don’t currently build releases, so no need to worry about that patch.

   Indeed, and zeromq package is easy to install from the ports/pkg_add system for people building from source.

9. laanwj merged this on Dec 22, 2017
10. laanwj closed this on Dec 22, 2017

    ---

11. laanwj referenced this in commit 180a25596a on Dec 22, 2017
12. laanwj referenced this in commit 765a3ebb02 on Mar 6, 2018
13. deadalnix referenced this in commit 179fdb728a on Mar 27, 2020
14. PastaPastaPasta referenced this in commit 1ea89b0285 on Mar 27, 2020
15. PastaPastaPasta referenced this in commit 4a832e8345 on Mar 28, 2020
16. PastaPastaPasta referenced this in commit 00de0f94d5 on Mar 29, 2020
17. PastaPastaPasta referenced this in commit 652bb16d21 on Mar 31, 2020
18. UdjinM6 referenced this in commit a6b3d7d2a6 on Mar 31, 2020
19. PastaPastaPasta referenced this in commit 7b1f32082c on Apr 1, 2020
20. 10xcryptodev referenced this in commit 8cc575cced on May 16, 2020
21. 10xcryptodev referenced this in commit 45db031556 on May 17, 2020
22. ckti referenced this in commit 1ece1b4028 on Mar 28, 2021
23. gades referenced this in commit 6db1fa619c on Jun 24, 2021
24. CryptoCentric referenced this in commit 7732baefae on Jul 2, 2021
25. CryptoCentric referenced this in commit 430e0c7120 on Jul 2, 2021
26. ftrader referenced this in commit 44d102f75f on Aug 13, 2021
27. DrahtBot locked this on Sep 8, 2021

Contributors
theuni jonasschnelli fanquake laanwj

Labels
Build system