[depends] zeromq 4.2.3 #11986

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:zeromq-4-2-3 changing 3 files +40 −5
  1. fanquake commented at 9:47 am on December 22, 2017: member

    This is a followup to #9254 and #11981. Zeromq 4.2.3 was released just after #9254 was merged, and contains a years worth of improvements/bug fixes. See the release notes here.

    Todo:

  2. fanquake added the label Build system on Dec 22, 2017
  3. fanquake requested review from jonasschnelli on Dec 22, 2017
  4. fanquake requested review from theuni on Dec 22, 2017
  5. da2ce7 commented at 5:58 am on December 24, 2017: none

    @fanquake Hello.

    With all the dependencies that are linked in; as I understand zeromq isn’t turned on used by default, however it is linked by default.

    My main concern is that in dependencies there is some reflective code that has been designed to compromise Bitcoin Core. Is this a realistic concern?; how much dew-diligence do we need to audit the history of linked libs to make sure there isn’t any nastyness?

  6. jonasschnelli commented at 6:31 am on January 4, 2018: contributor

    @da2ce7: zmq will be enabled by default if present on the system,… and therefore through “depends/” builds (gitian, “official binaries”), it’s enabled.

    AFAIK even when zmq has not been enabled via -zmqpubhashblock (or similar), the code calls zmq_init(1);.

    So… yeah. Unsure.

    EDIT: However, this is unrelated to this PR.

  7. jonasschnelli commented at 8:48 pm on January 5, 2018: contributor
    Linux build failed (haven’t checked why exactly). https://bitcoin.jonasschnelli.ch/build/446
  8. jonasschnelli commented at 8:50 pm on January 5, 2018: contributor
    qt/bitcoin-qt: symbol pthread_setname_np from unsupported version GLIBC_2.12 Seems to be related to this PR.
  9. fanquake commented at 0:10 am on February 16, 2018: member

    The issue here is that ZeroMQ started using pthread_set_name_np to name their background threads, see https://github.com/zeromq/libzmq/pull/2367.

    pthread_set_name_np was introduced in GLIB 2.12, and the max GLIB version allowed by symbol-check.py is 2.11.

    We are currently using pthread_set_name_np for thread naming in util.cpp. Might be time to consider increasing the max allowed GLIB version in symbol-check.py ?

  10. laanwj commented at 6:42 pm on February 22, 2018: member

    Might be time to consider increasing the max allowed GLIB version in symbol-check.py ?

    This is likely going to cause complaints, because it means the binary won’t run on some distributions anymore. Not sure what the minimum glibc in commonly used (stable) distributions is, though.

    We could open a separate issue for that.

  11. depends: zeromq 4.2.3 8f79226361
  12. depends: patch pthread_set_name_np out of zeromq 13a399a46c
  13. fanquake force-pushed on Mar 5, 2018
  14. laanwj commented at 9:05 pm on March 5, 2018: member
    utACK 13a399a46
  15. theuni approved
  16. theuni commented at 9:25 pm on March 5, 2018: member
    utACK 13a399a46c0c3ba78a6c0ba06c58186dfaf9be2c
  17. laanwj merged this on Mar 6, 2018
  18. laanwj closed this on Mar 6, 2018
  19. laanwj referenced this in commit 765a3ebb02 on Mar 6, 2018
  20. greenaddress commented at 2:14 pm on July 17, 2018: contributor
    @fanquake Was the autogen.sh step removal intentional? Seems to break things (I apply this https://github.com/zeromq/libzmq/pull/3140/commits/58d13395ece1fa0dd9b0583d736af4ac342c1267 to libzmq for ndk builds)
  21. theuni commented at 3:09 pm on July 17, 2018: member
    @greenaddress The autogen.sh is only needed if you’re not building from their bootstrapped release tarball. If you’re building from some git commit, you’ll need to add it back.
  22. greenaddress commented at 3:23 pm on July 17, 2018: contributor

    @theuni fair enough. I’m doing a PR to backport a zmq upstream but unmerged patch https://github.com/zeromq/libzmq/pull/3140/commits/58d13395ece1fa0dd9b0583d736af4ac342c1267 in (preparing for PR) https://github.com/greenaddress/bitcoin/commits/zmq_clang_depends and it needs autogen.sh otherwise fails with aclocal issues ( https://travis-ci.org/greenaddress/bitcoin/jobs/404902106 )

    More context: #11844 (comment)

    I’m aware of #13578 so i also backported it in case that gets merged first https://github.com/greenaddress/bitcoin/commits/zmq-upgrade-mruddy-patched

  23. greenaddress commented at 3:34 pm on July 17, 2018: contributor
    @theuni see https://github.com/bitcoin/bitcoin/pull/13689
  24. fanquake deleted the branch on Jul 18, 2018
  25. MarcoFalke referenced this in commit 8c36432791 on Jul 19, 2018
  26. laanwj referenced this in commit 2d4749b366 on Sep 17, 2018
  27. deadalnix referenced this in commit 329971ea7c on Mar 31, 2020
  28. 10xcryptodev referenced this in commit 8cc575cced on May 16, 2020
  29. 10xcryptodev referenced this in commit 45db031556 on May 17, 2020
  30. PastaPastaPasta referenced this in commit bcdd83da7c on Jun 9, 2020
  31. PastaPastaPasta referenced this in commit 274911cbb9 on Jun 9, 2020
  32. PastaPastaPasta referenced this in commit 7b0df1dd89 on Jun 10, 2020
  33. PastaPastaPasta referenced this in commit e9d78ed017 on Jun 10, 2020
  34. PastaPastaPasta referenced this in commit cd96e52b4d on Jun 11, 2020
  35. PastaPastaPasta referenced this in commit 1ee1074e22 on Jun 11, 2020
  36. PastaPastaPasta referenced this in commit b31cb3a365 on Jun 12, 2020
  37. PastaPastaPasta referenced this in commit e84e74cab5 on Jun 14, 2020
  38. fanquake referenced this in commit c6b730dbfc on Aug 25, 2020
  39. sidhujag referenced this in commit 8e9b5a0862 on Aug 25, 2020
  40. gades referenced this in commit 6db1fa619c on Jun 24, 2021
  41. gades referenced this in commit 25565e3b1e on Jun 24, 2021
  42. CryptoCentric referenced this in commit 430e0c7120 on Jul 2, 2021
  43. CryptoCentric referenced this in commit 7d0e2fe99b on Jul 2, 2021
  44. ftrader referenced this in commit 2dc2916124 on Aug 13, 2021
  45. dzutto referenced this in commit 6390d05eaf on Sep 7, 2021
  46. PastaPastaPasta referenced this in commit 22dd7bfa37 on Sep 8, 2021
  47. MarcoFalke locked this on Dec 16, 2021


fanquake da2ce7 jonasschnelli laanwj theuni greenaddress


jonasschnelli

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me