Docs: tweak the OSX build instructions #11987

pull janstary wants to merge 2 commits into bitcoin:master from janstary:macos changing 1 files +55 −28

janstary commented at 10:17 AM on December 22, 2017: none
This is a revision of doc/build-osx.md, tested on 10.13.2
- Don't dictate Homebrew, mention also MacPorts and Fink
- Drop a link to a nonexistent section
- Mention ./configre --prefix, --disable-wallet and --without-gui
- Include make install
- Fix the bitcoin.conf instructions (the directory doesn't exist yet)
Tweak the OSX build instructions 4d3ed13708
janstary commented at 10:20 AM on December 22, 2017: none

I tested the MacPort port instructions to install exactly the dependencies. Can someone please also check the brew version? At least autoconf and zmq seem to be missing, put perhaps in brew they get pulled in as further dependencies? Can someone using Fink please cook the appropriate fink install line?
jonasschnelli commented at 10:23 AM on December 22, 2017: contributor

Thanks for contributing! I think we should not mention that Bitcoin Core can be installed via brew. It looks like a recommendation and we really have no control what's in that package.
fix typos in build-osx.md 5165126602
fanquake commented at 10:30 AM on December 22, 2017: member

Homebrew is used because there are multiple developers using it, and we know it works. Will you maintain the port/fink instructions for future releases?

Have you checked/updated the configure.ac checks for port installed dependencies? We were going to remove those checks at one point, so they may be out of date. I’m not sure if anything special is required for fink?

Homebrew is also mentioned in other parts of the documentation, such as for installing testing dependencies. Do we need to add port/fink specific instructions in those places as well?
fanquake added the label Docs on Dec 22, 2017
fanquake added the label MacOSX on Dec 22, 2017
janstary commented at 3:20 PM on December 22, 2017: none

I only use MacPorts and can atest that this is how to install the dependencies.

The port as installed by MacPorts is simply version 0.14.1; I am in the middle of updating it.

I don't use Homebrew or Fink, so someone else ha to come up with the right install line to get the dependencies. At any rate, MacPorts, Homebrew and Fink are the prevalent packege managers for MacOS, so it seems relevant to mention them as a way to install dependencies (or even Bitcoin Core itself).
janstary renamed this:
~~Tweak the OSX build instructions~~
Docs: tweak the OSX build instructions
on Dec 22, 2017
rbkhmrcr commented at 3:04 PM on January 6, 2018: none

I just did a fresh install using brew and everything worked as expected (besides a bunch of warnings of comparisons of numbers of inconsistent types), so can confirm all dependencies are pulled in at some point. Also, this may seem really trivial but could it be added that people may have to turn their adblock off to download the community version of qt? I thought I was on a wild goose chase!
MarcoFalke commented at 7:08 PM on February 10, 2018: member

Needs rebase if still relevant
fanquake commented at 11:13 AM on February 14, 2018: member

Closing for now. You can re-open when you've rebased, and addressed comments.
fanquake closed this on Feb 14, 2018
janstary commented at 9:27 AM on March 1, 2018: none

I will prepare a better PR based on 0.16.0
janstary deleted the branch on Mar 1, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Labels