[depends] Fix Qt build with Xcode 9 #11995

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:macos-10-13-fix-depends-qt changing 2 files +72 −1
  1. fanquake commented at 3:29 am on December 23, 2017: member

    Building Qt in depends is currently broken with versions of Xcode > 9.0 (on both 10.12.x and 10.13.x). We’ll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

    Fixes #11461 Related upstream issues: https://bugreports.qt.io/browse/QTBUG-63401, https://bugreports.qt.io/browse/QTBUG-62266.

  2. fanquake added the label Build system on Dec 23, 2017
  3. fanquake added the label MacOSX on Dec 23, 2017
  4. fanquake requested review from theuni on Dec 23, 2017
  5. eugene-sy referenced this in commit ba3f8655c6 on Jan 11, 2018
  6. MarcoFalke commented at 4:44 pm on February 16, 2018: member

    We’ll bump our Clang/Qt/SDK again soon, however this fixes building in the interim.

    What is the status of this?

  7. MarcoFalke added this to the milestone 0.16.1 on Mar 3, 2018
  8. MarcoFalke commented at 3:40 pm on March 3, 2018: member
    Looks like this is for backport?
  9. MarcoFalke added the label Needs backport on Mar 3, 2018
  10. Sjors commented at 4:24 pm on March 5, 2018: member
  11. laanwj commented at 6:01 pm on March 5, 2018: member

    Sadly fails: https://gist.github.com/Sjors/971ba439a5662b3992113339649631b4

    Strange! That seems related to sse4 instructions support, not Qt. Do you have the same problem without this change?

  12. theuni approved
  13. theuni commented at 6:37 pm on March 5, 2018: member
    As discussed in-person, build failure looks unrelated. utACK after switching to a patch from upstream qt’s git.
  14. [Depends] Fix Qt build with Xcode 9.2 2b1f794574
  15. fanquake force-pushed on Mar 5, 2018
  16. laanwj commented at 7:42 pm on March 5, 2018: member
    utACK 2b1f7945747b59215b5f07573cf6cae4a269d3bf
  17. laanwj merged this on Mar 5, 2018
  18. laanwj closed this on Mar 5, 2018

  19. laanwj referenced this in commit 9a75902c56 on Mar 5, 2018
  20. Sjors commented at 9:09 pm on March 5, 2018: member
    I can’t reproduce my issue with a fresh clone and it went away with make clean.
  21. fanquake referenced this in commit b7d95037f4 on Mar 7, 2018
  22. fanquake referenced this in commit 686cb86002 on Mar 11, 2018
  23. laanwj referenced this in commit 845838c445 on Mar 14, 2018
  24. HashUnlimited referenced this in commit 9471ef439f on Mar 16, 2018
  25. fanquake deleted the branch on Apr 12, 2018
  26. fanquake removed the label Needs backport on Apr 12, 2018
  27. fanquake commented at 2:02 am on April 12, 2018: member
    Removed “Needs Backport” as it was done in #12636.
  28. fanquake referenced this in commit 9bb1a16523 on Apr 26, 2018
  29. laanwj referenced this in commit 1618c63095 on May 15, 2018
  30. XNotCopy referenced this in commit a31fc4d9a4 on Jun 21, 2018
  31. ccebrecos referenced this in commit df94b5d1cf on Sep 14, 2018
  32. UdjinM6 referenced this in commit b652a91696 on Sep 25, 2018
  33. UdjinM6 referenced this in commit a44d1d560e on Sep 26, 2018
  34. codablock referenced this in commit 5cf7253298 on Sep 28, 2018
  35. codablock referenced this in commit 199717354f on Sep 28, 2018
  36. codablock referenced this in commit d817a38d9b on Sep 28, 2018
  37. UdjinM6 referenced this in commit 8a1b513560 on Sep 30, 2018
  38. UdjinM6 referenced this in commit fba4b213cb on Oct 3, 2018
  39. CryptoCentric referenced this in commit 2b0670db2d on Mar 13, 2019
  40. PastaPastaPasta referenced this in commit ad7de75776 on Mar 14, 2020
  41. PastaPastaPasta referenced this in commit 668f04590d on Mar 14, 2020
  42. PastaPastaPasta referenced this in commit b158839595 on Mar 19, 2020
  43. PastaPastaPasta referenced this in commit d8520cac50 on Mar 28, 2020
  44. PastaPastaPasta referenced this in commit b248a3f2e2 on Mar 29, 2020
  45. UdjinM6 referenced this in commit fbf96a0568 on Mar 30, 2020
  46. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-05 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me