Remove most recent transaction timestamp stuff from nTimeSmart #12024

1. 
   achow101 commented at 1:43 am on December 26, 2017: member

   This will show accurate and correct timestamps for transactions. Order in listtransactions is still maintained because that ordering is done separately from the timestamps.

   Fixes #11703 and fixes #6662

2. fanquake added the label Wallet on Dec 26, 2017
3. 
   BashCo commented at 7:40 pm on December 26, 2017: none

   fix-timesmart appears to fix the issue I experienced with incorrect transaction timestamps when importing watch-only addresses. After compiling, I used -rescan as well as -zapwallettxes, neither of which resolved the issue (on my end). After making a new wallet and reimporting with importmulti, the timestamps are correct.
4. 
   meshcollider commented at 10:12 pm on December 26, 2017: contributor

   Unsure on the reasoning behind this initial behaviour so can’t ACK/NACK until Luke or someone else explains. But looks like src/wallet/test/wallet_tests.cpp needs updating too.

   Note I don’t think GitHub doesn’t understand “Fixes X and Y” when it does it’s auto-close, you probably have to write Fixes X, fixes Y.

5. 
   gmaxwell commented at 10:56 am on January 8, 2018: contributor

   @luke-jr
6. Remove most recent transaction timestamp stuff from nTimeSmart

   This will show accurate and correct timestamps while maintaining
   proper transaction order in listtransactions.

   56d9ffab7d
7. achow101 force-pushed on Jan 8, 2018
8. 
   luke-jr commented at 5:20 pm on February 26, 2018: member

   The idea IIRC was simply to ensure timestamps move forward at least in ordinary circumstances.
9. MarcoFalke added the label Needs rebase on Jun 6, 2018
10. MarcoFalke removed the label Needs rebase on Nov 8, 2018
11. 
    DrahtBot commented at 11:42 pm on November 8, 2018: member
12. DrahtBot added the label Needs rebase on Nov 8, 2018
13. 
    MarcoFalke commented at 5:38 pm on April 19, 2019: member

    There hasn’t been much activity lately and the patch still needs rebase, so I am closing this for now. Please let me know when you want to continue working on this, so the pull request can be re-opened.
14. MarcoFalke closed this on Apr 19, 2019

    ---

15. MarcoFalke added the label Up for grabs on Apr 19, 2019
16. laanwj removed the label Needs rebase on Oct 24, 2019
17. MarcoFalke locked this on Dec 16, 2021

Contributors
achow101 BashCo meshcollider gmaxwell luke-jr DrahtBot MarcoFalke

Labels
Wallet Up for grabs