[trivial] Implements a virtual destructor on the BaseRequestHandler class. #12050

pull l2a5b1 wants to merge 1 commits into bitcoin:master from l2a5b1:patch/BaseRequestHandler-virtual-dtor changing 1 files +1 −0

l2a5b1 commented at 4:25 PM on December 29, 2017: contributor

Granted that there is no undefined behavior in the current implementation, this PR implements a virtual destructor on the BaseRequestHandler class to protect against undefined behavior in the event that an object of a potential future derived BaseRequestHandler class with a destructor is destroyed through a pointer to this base class.

This PR also fixes "warning: delete called on 'BaseRequestHandler' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]" warnings in environments where the project is built with the -Wsystem-headers flag; or environments where the -Wdelete-non-virtual-dtor diagnostics flag fires from system headers.

Implements a virtual destructor on the BaseRequestHandler class.

Implements a virtual destructor on the BaseRequestHandler class to protect against undefined behavior in
the event that a derived BaseRequestHandler class has a destructor and an object of such derived class
is destroyed through a pointer to its base class.

bdb3231bee

laanwj added the label Refactoring on Dec 30, 2017
laanwj commented at 10:44 AM on December 30, 2017: member

utACK
l2a5b1 renamed this:
~~Implements a virtual destructor on the BaseRequestHandler class.~~
[trivial] Implements a virtual destructor on the BaseRequestHandler class.
on Jan 14, 2018
fanquake commented at 12:52 PM on January 29, 2018: member

utACK bdb3231
promag commented at 12:55 PM on January 29, 2018: member

utACK bdb3231.
laanwj merged this on Feb 6, 2018
laanwj closed this on Feb 6, 2018
laanwj referenced this in commit 1462bde767 on Feb 6, 2018
l2a5b1 deleted the branch on Feb 12, 2018
PastaPastaPasta referenced this in commit fc4cafffec on Apr 13, 2020
PastaPastaPasta referenced this in commit c39255abc4 on Jun 9, 2020
PastaPastaPasta referenced this in commit d295cadffd on Jun 9, 2020
PastaPastaPasta referenced this in commit 38f7460c59 on Jun 10, 2020
PastaPastaPasta referenced this in commit 2ecd2d3d54 on Jun 10, 2020
PastaPastaPasta referenced this in commit 2ec68225ad on Jun 11, 2020
PastaPastaPasta referenced this in commit 5bda48bb56 on Jun 11, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels