Fix addrman crashes #1207

1. 
   sipa commented at 7:39 PM on May 5, 2012: member

   A function returned the element to remove from a bucket, instead of its position in that bucket. This function was only called when a tried bucket overflowed, which only happens after many outgoing connections have been made.

   Closes: #1065, #1156

2. Add extra asserts to addrman 29a86a1735
3. Fix addrman crashes

   A function returned the element to remove from a bucket, instead of its
   position in that bucket. This function was only called when a tried
   bucket overflowed, which only happens after many outgoing connections
   have been made.
   
   Closes: #1065, #1156

   56f1e91239
4. Bugfix: store source address in addrman bd1aabe941
5. 
   gavinandresen commented at 11:54 PM on May 5, 2012: contributor

   ACK

6. 
   gmaxwell commented at 5:23 AM on May 6, 2012: contributor

   This has survived about 10 hours of running inside valgrind here on a node that previously crashed and with some tweaks to make it more likely to crash. It also survived a new node bringup. The code looks okay to me, so I'm going to go ahead and pull it in the hopes of getting more people testing it on master.

7. gmaxwell referenced this in commit 4fdc8a62d0 on May 6, 2012
8. gmaxwell merged this on May 6, 2012
9. gmaxwell closed this on May 6, 2012

   ---

10. coblee referenced this in commit 0b0e9a5c2c on Jul 17, 2012
11. sipa deleted the branch on Jun 23, 2017
12. suprnurd referenced this in commit e1702cd4ec on Dec 5, 2017
13. lateminer referenced this in commit 13519e9ead on Jan 22, 2019
14. lateminer referenced this in commit 1968f61075 on Jan 10, 2020
15. Bushstar referenced this in commit e9f0d4f758 on May 9, 2021
16. DrahtBot locked this on Sep 8, 2021

Milestone
0.6.2