A function returned the element to remove from a bucket, instead of its position in that bucket. This function was only called when a tried bucket overflowed, which only happens after many outgoing connections have been made.
Fix addrman crashes #1207
pull sipa wants to merge 3 commits into bitcoin:master from sipa:fix_addrman changing 2 files +25 −3-
sipa commented at 7:39 pm on May 5, 2012: member
-
Add extra asserts to addrman 29a86a1735
-
Fix addrman crashes
A function returned the element to remove from a bucket, instead of its position in that bucket. This function was only called when a tried bucket overflowed, which only happens after many outgoing connections have been made. Closes: #1065, #1156
-
Bugfix: store source address in addrman bd1aabe941
-
gavinandresen commented at 11:54 pm on May 5, 2012: contributorACK
-
gmaxwell commented at 5:23 am on May 6, 2012: contributorThis has survived about 10 hours of running inside valgrind here on a node that previously crashed and with some tweaks to make it more likely to crash. It also survived a new node bringup. The code looks okay to me, so I’m going to go ahead and pull it in the hopes of getting more people testing it on master.
-
gmaxwell referenced this in commit 4fdc8a62d0 on May 6, 2012
-
gmaxwell merged this on May 6, 2012
-
gmaxwell closed this on May 6, 2012
-
coblee referenced this in commit 0b0e9a5c2c on Jul 17, 2012
-
sipa deleted the branch on Jun 23, 2017
-
suprnurd referenced this in commit e1702cd4ec on Dec 5, 2017
-
lateminer referenced this in commit 13519e9ead on Jan 22, 2019
-
lateminer referenced this in commit 1968f61075 on Jan 10, 2020
-
Bushstar referenced this in commit e9f0d4f758 on May 9, 2021
-
DrahtBot locked this on Sep 8, 2021
Milestone
0.6.2
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-01 22:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-01 22:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me