...s used when there are MAX_OUTBOUND_CONNECTIONS connections. Also MAX_OUTBOUND_CONNECTIONS is no longer static. This had to be done so that it could be made extern for reading in bitcoingui.cpp, though this hopefully will not hurt anything else.
Fixes how the number of connections icon is shown. Now connect_4 icon i... #1208
pull ghost wants to merge 1 commits into bitcoin:master from changing 2 files +13 −9-
ghost commented at 5:08 AM on May 6, 2012: none
-
Fixes how the number of connections icon is shown. Now connect_4 icon is used when there are MAX_OUTBOUND_CONNECTIONS connections. Also MAX_OUTBOUND_CONNECTIONS is no longer static. This had to be done so that it could be made extern for reading in bitcoingui.cpp, though this hopefully will not hurt anything else. 5e3862b176
-
gmaxwell commented at 5:16 AM on May 6, 2012: contributor
I don't think we want it showing full bars when a user only has the maximum outbound connections. Not having full bars is pretty much the only UI incentive we create for people to get their inbound connections working.
-
-
laanwj commented at 6:23 AM on May 6, 2012: member
The idea is OK though, as it's more general, in that when MAX_OUTBOUND_CONNECTIONS changes the icon will still be correct.
But make sure that the "full" icon only shows when there are more than the maximum number of outbound connections.
Alternative option would be to track the number of outgoing and incoming connections separately and show a special icon when there are incoming connections.
Code comments:
- Don't use a shortcut to get MAX_OUTBOUND_CONNECTIONS from the core to the UI. You should expose it on the ClientModel interface, like the other counts such as number of blocks and number of connections.
-
ghost commented at 3:24 PM on May 6, 2012: none
I was under the impression that this was only outbound connections. Now that I have turned off my firewall, I see that I have more than 8 connections. Maybe the tool-tip could be changed to indicate inbound and outbound connections with a hint about port forwarding if there are no inbound connections?
-
laanwj commented at 4:13 PM on May 6, 2012: member
Yes, you could also do it the other way around and show a warning when there are no inbound connections. Many torrent clients do it that way.
-
gmaxwell commented at 6:11 PM on May 6, 2012: contributor
I'd prefer to not bludgeon people too much about inbound connections. Basically I want to encourage people to get inbound working when its easy for them to do so, but not have them worry about it if it's hard... and I certainly don't want to deal with a bunch of tech support burden. 'zomg my inbound isn't working'
-
laanwj commented at 6:15 PM on May 6, 2012: member
Right, viewed like that, it's fine the way it is. It's visible but very subtle. Closing the issue.
- laanwj closed this on May 6, 2012
- suprnurd referenced this in commit 8c16880b15 on Dec 5, 2017
- lateminer referenced this in commit 3dfafa84c2 on Jan 22, 2019
- DrahtBot locked this on Sep 8, 2021
