Add support to search the address book #12080

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-01-searchaddressbook changing 3 files +49 −19

promag commented at 4:12 PM on January 3, 2018: member

This PR adds support to search the address book for both receiving and sending addresses.

A specialisation of the QSortFilterProxyModel is added to implement the custom filtering.

<img width="757" alt="screen shot 2018-01-03 at 16 05 57" src="https://user-images.githubusercontent.com/3534524/34528196-0347d61e-f0a0-11e7-9bd3-535e9e34ceb8.png"> <img width="759" alt="screen shot 2018-01-03 at 16 00 58" src="https://user-images.githubusercontent.com/3534524/34528202-07c99f24-f0a0-11e7-8e34-cff6a1ba2364.png">

Closes #623.
[qt] Add support to search the address book c316fdffec
promag force-pushed on Jan 3, 2018
fanquake added the label GUI on Jan 3, 2018
jonasschnelli commented at 8:19 AM on January 4, 2018: contributor

Concept ACK
gmaxwell commented at 10:54 AM on January 8, 2018: contributor

Should we really be adding more functionality that encourages address reuse instead of doing the opposite?
promag commented at 3:07 PM on January 15, 2018: member

@gmaxwell I see your point. Although, from the UI point of view, search/filter is a basic thing to have near big lists.
in src/qt/addressbookpage.cpp:121 in c316fdffec
```
 153 | +    proxyModel = new AddressBookSortFilterProxyModel(type, this);
 154 |      proxyModel->setSourceModel(_model);
 155 | -    proxyModel->setDynamicSortFilter(true);
 156 | -    proxyModel->setSortCaseSensitivity(Qt::CaseInsensitive);
 157 | -    proxyModel->setFilterCaseSensitivity(Qt::CaseInsensitive);
 158 | -    switch(tab)
```
Sjors commented at 5:16 PM on February 8, 2018:

What was this doing originally?

promag commented at 5:33 PM on February 8, 2018:

This behaviour is now coded in L151.

Sjors commented at 5:47 PM on February 8, 2018:

I see. In that case I'm confused as to what ReceivingTab does. I only see the address book in the Send tab.

promag commented at 6:22 PM on February 8, 2018:

Create a request payments in "Receive" tab and then go "File" -> "Receiving adresses...".

Sjors commented at 9:38 AM on February 9, 2018:

Found it, search works there as well.
Sjors commented at 5:20 PM on February 8, 2018: member

Perhaps in the future the address book can be used for something more privacy friendly (in other words, not literally addresses). In addition, maybe the address book and/or send screen can mark used addresses as such.

Looks like a simple enough change code-wise.

Tested, worked for me.
Sjors commented at 9:40 AM on February 9, 2018: member

ACK c316fdff.

Suggestion for future improvement: highlight matching characters using bold font.
laanwj commented at 2:25 PM on March 14, 2018: member

@sjors Thanks for testing! Good to finally close #623.
laanwj merged this on Mar 14, 2018
laanwj closed this on Mar 14, 2018
laanwj referenced this in commit 56cc022112 on Mar 14, 2018
PastaPastaPasta referenced this in commit 8717a90edb on Jun 10, 2020
PastaPastaPasta referenced this in commit f3e3d1e7ca on Jun 13, 2020
PastaPastaPasta referenced this in commit d2f1ebb96b on Jun 13, 2020
PastaPastaPasta referenced this in commit d3a19c5f42 on Jun 13, 2020
PastaPastaPasta referenced this in commit 20de0ec7db on Jun 17, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#623 Address book cannot be searched