[wallet] Remove segwit status check #12124

1. 
   ghost commented at 10:11 pm on January 8, 2018: none

   This is #11400 based on the current master.
2. 
   jnewbery commented at 3:23 pm on January 9, 2018: member

   ACK b233db7c0a60cec67252132b911f6a5d4e330128, but please retain the original authorship in the commit message.

   #11400 seems abandoned, so I think it’s fine to merge this once the commit message is fixed.

3. 
   jl2012 commented at 5:30 pm on January 9, 2018: contributor

   @jnewbery @laudaa sorry that I forgot #11400. I don’t think you need to revise the commit message just for authorship.

   ACK b233db7

4. 
   ghost commented at 5:32 pm on January 9, 2018: none

   @jnewbery I think I managed to do what you’ve requested. Mind checking again?
5. 
   jnewbery commented at 6:41 pm on January 9, 2018: member

   ACK b1a64bc4fff7405f20b8d4a4763427349daccb8f

   Since @jl2012 is happy with the commit message, no need to change it.

   For future reference, you can do the following to replace the most recent commit message with the commit message from a different commit:

   0git commit --amend --C <commit hash>
   

   In this case, you’d do:

   0git commit --amend -C b8016405d62a3592648267ca97312bae40ae72af # b801640... is jl2012's commit
   

6. 
   promag commented at 4:09 pm on January 10, 2018: member

   utACK b1a64bc.
7. 
   MarcoFalke commented at 4:18 pm on January 10, 2018: member

   NACK the current commit.

   I don’t think this works, as it requires that segwit is always active on mainnet, as the transactions would otherwise be rejected by your own node based on policy. Note, that your node is not required to be fully synced to create sending transactions.

8. 
   promag commented at 4:53 pm on January 10, 2018: member

   @MarcoFalke essentially this removes -walletprematurewitness which is only used in addwitnessaddress RPC. Sorry but I don’t understand your concern, can you elaborate?
9. 
   MarcoFalke commented at 6:05 pm on January 10, 2018: member

   See

   https://github.com/bitcoin/bitcoin/blob/45173fa6fca9537abb0a0554f731d14b9f89c456/src/validation.cpp#L561-L564

   which implies you can create segwit transactions with this pull request, but not send them.

10. 
    ghost commented at 1:41 pm on January 11, 2018: none

    Rebased again.
11. [wallet] Remove segwit status check

    Rebases the work by jl2012, the PR 11400.

    01ee71a608
12. fanquake added the label Wallet on Jan 13, 2018
13. 
    laanwj commented at 11:36 am on January 15, 2018: member

    I don’t think this works, as it requires that segwit is always active on mainnet

    So this needs to go deeper to ensure that segwit is always enabled on mainnet? After all, it activated, so it makes no sense to reject (creation of) segwit transactions before being synced to the point where segwit activates.

14. fanquake added this to the "In progress" column in a project

    ---

15. 
    laanwj commented at 9:08 pm on March 29, 2018: member

    I’m not sure about the status of this PR. There are some unaddressed concerns. Closing for now, let me know if you start work on it again and I’ll reopen.
16. laanwj closed this on Mar 29, 2018

    ---

17. fanquake removed this from the "In progress" column in a project

    ---

18. MarcoFalke locked this on Sep 8, 2021

Contributors
ghost jnewbery jl2012 promag MarcoFalke laanwj

Labels
Wallet