Wallet: Support disabling implicit Segwit operation #12146

1. 
   luke-jr commented at 10:48 am on January 11, 2018: member

   This optional feature (disabled by default) leaves Segwit wallet support mostly as-is, except:

   1. It disables automatic implied Segwit recognition for keys not explicitly generated as Segwit. This means each Segwit address generated needs a new backup, same as previous versions.
   2. Default address/change type is legacy.

   OUTPUT_TYPE_DEFAULT is changed to an actual OutputType value, in expectation of reuse by #12119 as well as enabling the possibility of having the implicit segwit flag be set per-wallet once we have runtime wallet loading.

2. fanquake added the label Wallet on Jan 11, 2018
3. 
   TheBlueMatt commented at 5:18 pm on January 11, 2018: member

   I see little reason to do this. While we shouldn’t make a habit of recognizing outputs to mutations of addresses we’ve given out, if someone sends you funds to a SegWit address, and you wish to refuse it, you’re welcome to not honor the payment. Instead, we should be moving towards longer-term goals like splitting the HD chain across address types and recognizing payment only to addresses we’ve given out in a non-backup-breaking way.
4. 
   luke-jr commented at 7:33 pm on January 11, 2018: member

   Without this, there is currently no way to even detect they were sent to a Segwit mutation of an address.
5. 
   jnewbery commented at 8:03 pm on January 11, 2018: member

   Much discussion of this PR here: https://botbot.me/freenode/bitcoin-core-dev/2018-01-11/?msg=95652211&page=5

   I’d support fixing the general case of address malleation. I don’t think this is the correct approach, and don’t think it should hold up v0.16, for the reasons enumerated in IRC. Concept NACK from me.

6. luke-jr force-pushed on Jan 12, 2018
7. Wallet: Support disabling implicit Segwit operation cc78a98417
8. luke-jr force-pushed on Mar 31, 2018
9. 
   luke-jr commented at 7:07 pm on March 31, 2018: member

   Rebased (which simplified it quite a bit).
10. MarcoFalke added the label Needs rebase on Jun 6, 2018
11. 
    MarcoFalke commented at 10:57 am on August 26, 2018: member

    Closing for now. Let me know when you want to continue working on this.
12. MarcoFalke closed this on Aug 26, 2018

    ---

13. laanwj removed the label Needs rebase on Oct 24, 2019
14. MarcoFalke locked this on Dec 16, 2021

Contributors
luke-jr TheBlueMatt jnewbery MarcoFalke

Labels
Wallet