Fix ListCoins test failure due to unset g_address_type, g_change_type #12150

1. 
   ryanofsky commented at 1:06 pm on January 11, 2018: member

   New global variables were introduced in #11403 and not setting them causes:

   0test_bitcoin: wallet/wallet.cpp:4199: CTxDestination GetDestinationForKey(const CPubKey&, OutputType): Assertion `false' failed.
   1unknown location(0): fatal error in "ListCoins": signal: SIGABRT (application abort requested)
   

   It’s possible to reproduce the failure reliably by running:

   0src/test/test_bitcoin --log_level=test_suite --run_test=wallet_tests/ListCoins
   

   Failures happen nondeterministically because boost test framework doesn’t run tests in a specified order, and tests that run previously can set the global variables and mask the bug.

   Example travis failure: https://travis-ci.org/bitcoin/bitcoin/builds/327642495

2. Fix ListCoins test failure due to unset g_address_type, g_change_type

   New global variables were introduced in #11403 and not setting them causes:
   
       test_bitcoin: wallet/wallet.cpp:4199: CTxDestination GetDestinationForKey(const CPubKey&, OutputType): Assertion `false' failed.
       unknown location(0): fatal error in "ListCoins": signal: SIGABRT (application abort requested)
   
   It's possible to reproduce the failure reliably by running:
   
       src/test/test_bitcoin --log_level=test_suite --run_test=wallet_tests/ListCoins
   
   Failures happen nondeterministically because boost test framework doesn't run
   tests in a specified order, and tests that run previously can set the global
   variables and mask the bug.

   f765bb3788
3. laanwj added the label Tests on Jan 11, 2018
4. 
   laanwj commented at 1:09 pm on January 11, 2018: member

   utACK https://github.com/bitcoin/bitcoin/pull/12150/commits/f765bb37880443061eb5f0a9cd5897e33732182d, good catch.
5. 
   sipa commented at 1:15 pm on January 11, 2018: member

   utACK
6. 
   promag commented at 1:31 pm on January 11, 2018: member

   utACK f765bb3.
7. MarcoFalke merged this on Jan 11, 2018
8. MarcoFalke closed this on Jan 11, 2018

   ---

9. MarcoFalke referenced this in commit 92a810d04b on Jan 11, 2018
10. sipa referenced this in commit 252ae7111c on Feb 14, 2018
11. MarcoFalke referenced this in commit 6012f1caf7 on Mar 3, 2018
12. PastaPastaPasta referenced this in commit 7d12744e2f on Jan 17, 2020
13. PastaPastaPasta referenced this in commit 65a196e3d9 on Jan 17, 2020
14. PastaPastaPasta referenced this in commit 98ae41c821 on Feb 12, 2020
15. PastaPastaPasta referenced this in commit a7dab7e9c9 on Feb 12, 2020
16. PastaPastaPasta referenced this in commit 5ca5adca7b on Apr 6, 2020
17. PastaPastaPasta referenced this in commit a4c7a60f18 on Jun 27, 2021
18. DrahtBot locked this on Sep 8, 2021

Contributors
ryanofsky laanwj sipa promag

Labels
Tests