[WIP] misc. backwards compatibility tests #12152

1. 
   Sjors commented at 2:19 pm on January 11, 2018: member

   Builds on top of #12134.

   Tests:

   • v0.16 generated wallets don’t work on older versions
   • the five SegWit wallet scenario’s (including bech32 address)

   Test framework changes (or: things I’m doing wrong):

   • method to copy wallet
   • method to push and pop wallet backups
   • remember network topology between start and restart

   Suggestions for additional tests welcome. I’ll make individual PR’s later.

2. [scripts] build earlier releases 878fc2ffd9
3. [tests] check v0.14.2 and v0.15.1 backwards compatibility 51b8792df8
4. [travis] compile v0.14.2 v0.15.1 and run backwards compatibity tests 007a339539
5. in contrib/devtools/previous_release.sh:25 in 2d4cce594e outdated

   21@@ -20,17 +22,23 @@ while getopts ":hfrd" opt; do
   22       echo "  -f   Configure for functional tests"
   23       echo "  -r   Remove existing directory"
   24       echo "  -d   Use depends"
   25+      echo "  -b   configure --with-incompatible-bdb"
   

   ---

   ---

   

   Sjors commented at 2:20 pm on January 11, 2018:

   I’m not using this. Will remove unless someone wants to keep it.
6. Sjors force-pushed on Jan 11, 2018
7. in test/functional/backwards_compatibility.py:209 in ec4268aaeb outdated

   204+
   205+        # Balance won't immedidately update:
   206+        self.nodes[1].rescanblockchain()
   207+        assert_equal(self.nodes[1].getbalance("p2sh-post-backup"), 1)
   208+        assert_equal(self.nodes[1].getbalance("bech32-post-backup"), 1) 
   209+        assert_equal(self.nodes[1].getbalance("p2sh-disappear"), 0)
   

   ---

   ---

   

   Sjors commented at 6:21 pm on January 11, 2018:

   @sipa I’m not sure how to interpret scenario 1. It seems that, for keys generated after a backup was made, funds are irretrievable if the user doesn’t create the correct address type for each new key. Is this a bug?
8. [tests] misc. backward compatibity tests 8af73179c3
9. Sjors force-pushed on Jan 11, 2018
10. 
    Sjors commented at 2:33 pm on January 12, 2018: member

    I need to rewrite these tests so they don’t use the account feature. See also IRC log.
11. fanquake added the label Tests on Jan 13, 2018
12. 
    fanquake commented at 12:46 pm on April 26, 2018: member

    Given that this has been work in progress for a few months, and “I need to rewrite these tests so they don’t use the account feature”, I’m closing this for now. Can be re-opened after it’s been re-written and rebased. Review can be focussed on #12134 as well.
13. fanquake closed this on Apr 26, 2018

    ---

14. MarcoFalke locked this on Sep 8, 2021

Contributors
Sjors fanquake

Labels
Tests