http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html
Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) #12168
pull jsarenik wants to merge 1 commits into bitcoin:master from jsarenik:jasan/fcntl.h changing 1 files +1 −1-
jsarenik commented at 11:22 AM on January 12, 2018: none
-
648bdc8cc0
Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/)
http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html
-
jsarenik commented at 11:26 AM on January 12, 2018: none
Rationale: compiling on musl-based system (Alpine Linux for example) produces warnings. It just should be without
sys/. - fanquake added the label Refactoring on Jan 12, 2018
- MarcoFalke added the label Build system on Jan 12, 2018
- MarcoFalke assigned theuni on Jan 12, 2018
-
MarcoFalke commented at 9:17 PM on January 12, 2018: member
utACK 648bdc8cc09c85748967b86347bbc7825e339d5f
- theuni approved
-
theuni commented at 9:27 PM on January 12, 2018: member
Heh, I have the same commit queued up locally from testing with musl this week.
I believe there are some ancient OSs that may only have the sys/fcntl.h version, but I'm ok with not adding detection until someone complains about an actual failed build.
utACK 648bdc8cc09c85748967b86347bbc7825e339d5f
-
fanquake commented at 4:57 AM on January 13, 2018: member
utACK 648bdc8
- MarcoFalke merged this on Jan 13, 2018
- MarcoFalke closed this on Jan 13, 2018
- MarcoFalke referenced this in commit 45cf8a03cb on Jan 13, 2018
- jsarenik deleted the branch on Jan 13, 2018
- PastaPastaPasta referenced this in commit b216f9ce43 on Jan 17, 2020
- PastaPastaPasta referenced this in commit 85c5a03ab3 on Jan 22, 2020
- PastaPastaPasta referenced this in commit 4c58ae60b7 on Jan 22, 2020
- PastaPastaPasta referenced this in commit 0daed895ad on Jan 29, 2020
- PastaPastaPasta referenced this in commit 3b8f5ae66d on Jan 29, 2020
- PastaPastaPasta referenced this in commit 77153fe420 on Jan 29, 2020
- PastaPastaPasta referenced this in commit 923126a663 on Jan 31, 2020
- ckti referenced this in commit 65891cd314 on Mar 28, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels