scripted-diff: change kB to kvB, kilobyte to kilovbyte for transaction fee rate things #12180

pull achow101 wants to merge 2 commits into bitcoin:master from achow101:use-vbytes changing 13 files +42 −42

achow101 commented at 2:25 AM on January 14, 2018: member

Renames kB and kilobyte to kvB and kilovbyte respectively in order to make clear the fee rates are in virtual bytes rather than actual bytes.
achow101 renamed this:
~~Use vbytes~~
scripted-diff: change kB to kvB, kilobyte to kilovbyte
on Jan 14, 2018

scripted-diff: change kB to kvB, kilobyte to kilovbyte

Renames kB and kilobyte to kvB and kilovbyte respectively in order
to make clear the fee estimates are in virtual bytes rather than
actual bytes.

-BEGIN VERIFY SCRIPT-
sed -i 's/\<\kB\>/\kvB/g' src/init.cpp
sed -i 's/\<\kB\>/\kvB/g' src/*.h
sed -i 's/\<\kB\>/\kvB/g' src/policy/*.h
sed -i 's/\<\kB\>/\kvB/g' src/policy/*.cpp
sed -i 's/\<\kB\>/\kvB/g' src/qt/*.cpp
sed -i 's/\<\kB\>/\kvB/g' src/rpc/*.cpp
sed -i 's/\<\kB\>/\kvB/g' src/wallet/*.cpp
sed -i 's/\<kilobyte\>/\kilovbyte/g' src/wallet/*.cpp
sed -i 's/\<kilobyte\>/\kilovbyte/g' src/rpc/*.cpp
sed -i 's/\<kilobyte\>/\kilovbyte/g' src/qt/*.cpp
sed -i 's/\<kilobyte\>/\kilovbyte/g' src/*.cpp
sed -i 's/\<kilobyte\>/\kilovbyte/g' src/policy/*.h
sed -i 's/\<kilobyte\>/\kilovbyte/g' src/policy/*.cpp
sed -i 's/\<\kB\>/\kvB/g' src/test/*.cpp
-END VERIFY SCRIPT-

0d0de9ad77

Undo accidental scripted diff change c9d5fe8682
achow101 force-pushed on Jan 14, 2018
fanquake added the label TX fees and policy on Jan 14, 2018
achow101 renamed this:
~~scripted-diff: change kB to kvB, kilobyte to kilovbyte~~
scripted-diff: change kB to kvB, kilobyte to kilovbyte for transaction fee rate things
on Jan 16, 2018
Sjors commented at 5:25 PM on January 17, 2018: member

This disabimguation is useful, but for the UI "virtual kilobyte", "v-kilobyte", "virtual kB" or "v-kB" would be more readable than "kilovbyte" and "kvB".

<img width="717" alt="schermafbeelding 2018-01-17 om 18 24 05" src="https://user-images.githubusercontent.com/10217/35056925-9f77e6f0-fbb3-11e7-9224-687df74da0a4.png">

It will matter less if and when we switch to satoshi per byte (sat/vB or sat/vByte).
Sjors commented at 8:08 AM on January 19, 2018: member

Some IRC discussion.

Another approach would be to just stick to "byte" in the UI and use tooltips where necessary to point out it's technically "virtual bytes".

For RPC more precise technical terminology makes sense.
MarcoFalke commented at 9:59 PM on February 21, 2018: member

Tend to NACK.

We shouldn't need to specify that the size is virtual. Either the user knows what virtual means, so they know that all sizes that involve transaction fees are virtual. Or they don't, in which case it just adds confusion.
Sjors commented at 9:43 AM on February 22, 2018: member

I tend to agree with @MarcoFalke, though I'm in favor of explaining this in at least some RPC call docs and tooltips.
achow101 closed this on Mar 1, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Labels