RFC: Rename -walletdir option to -walletsdir (scripted-diff) #12221

1. 
   ryanofsky commented at 7:16 pm on January 18, 2018: member

   Reasons for rename:

   1. Default value is <datadir>/wallets so calling it -walletsdir instead of -walletdir would be more internally consistent.
   2. Directory can contain more than one wallet so plural makes sense
   3. This makes it harder to confuse -walletdir option with -wallet option if we store wallets in their own directories as proposed in #11466 (comment) and implemented in https://github.com/bitcoin/bitcoin/pull/12216
2. scripted-diff: rename -walletdir options -walletsdir

   Reasons for rename:
   
     1) Default value is `<datadir>/wallets` so calling it `-walletsdir` instead
        of `-walletdir` would be more internally consistent
   
     2) Directory can contain more than one wallet so plural makes more sense
   
     3) This makes it harder to confuse -walletdir option with -wallet option
        if we store wallets in their own directories as proposed in
        https://github.com/bitcoin/bitcoin/pull/11466#issuecomment-335827526 and
        implemented in https://github.com/bitcoin/bitcoin/pull/12216
   
   -BEGIN VERIFY SCRIPT-
   git grep -l walletdir | xargs sed -i s/walletdir/walletsdir/g
   -END VERIFY SCRIPT-

   23fc59a941
3. 
   meshcollider commented at 7:19 pm on January 18, 2018: contributor

   This was suggested on the original PR here: #11466 (review)

   Both @laanwj and I agreed that walletdir is easier to remember and type :)

4. 
   laanwj commented at 7:21 pm on January 18, 2018: member

   I strongly prefer the singular name. I’m going to forget the ’s’ every time. I think it’s fairly clear that it’s a directory that it can contain multiple things, but in any case that belongs in the documentation, I don’t see a reason to rename it.
5. 
   jonasschnelli commented at 7:26 pm on January 18, 2018: contributor

   Agree with @laanwj.
6. 
   ryanofsky commented at 7:31 pm on January 18, 2018: member

   I did mention three reasons above (hopefully they make sense), and I don’t exactly know when you would be typing this option, but if getting rid of the s here is important do you also want to make the default location <datadir>/wallet?
7. 
   ryanofsky commented at 7:37 pm on January 18, 2018: member

   Ok, I don’t have a strong preference. Maybe you had a bad experience with the letter s. Was mostly concerned about confusion between -walletdir and -wallet options if different wallets stopped being stored together in a single bdb environment. Will close.
8. ryanofsky closed this on Jan 18, 2018

   ---

9. 
   laanwj commented at 7:48 pm on January 18, 2018: member

   Was mostly concerned about confusion between -walletdir and -wallet options if different wallets stopped being stored together in a single bdb environment. Will close.

   Yes, that’s a valid concern.

10. 
    Sjors commented at 8:14 am on January 19, 2018: member

    Fwiw, it’s “computer store”, not “computers store”, “grocery bag”, not “groceries bag”, “cookie jar”, not “cookies jar”. Though I’m sure there’s plenty of counter examples.
11. 
    promag commented at 11:30 am on September 26, 2018: member

    Another plural exception:

    0  QDesktopServices::DocumentsLocation
    1  QDesktopServices::FontsLocation
    2  QDesktopServices::ApplicationsLocation
    3* QDesktopServices::MusicLocation
    4  QDesktopServices::MoviesLocation
    5  QDesktopServices::PicturesLocation
    

    so wallet is like music 🎶 …

    (not english native speaker, so maybe there is a reason to be singular in this case)

12. MarcoFalke locked this on Sep 8, 2021

Contributors
ryanofsky meshcollider laanwj jonasschnelli Sjors promag