Log origin IP of RPC request #12223

issue Sjors opened this issue on January 19, 2018
  1. Sjors commented at 8:28 AM on January 19, 2018: member

    Currently when launching bitcoind with -debug=rpc the log is rather sparse, e.g. ThreadRPCServer method=validateaddres. If possible I'd like it to show the origin IP.

  2. fanquake added the label RPC/REST/ZMQ on Jan 19, 2018
  3. fanquake added the label Utils/log/libs on Jan 19, 2018
  4. laanwj commented at 9:51 AM on January 19, 2018: member

    There's a trade-off here between useful diagnostics, and the possibility of accidentally logging sensitive information. So this should not log individual RPC arguments. But more context information would be useful.

    I think it also should print the username.

  5. gmaxwell commented at 9:14 AM on February 4, 2018: contributor

    IP OKAY we could trigger on the logips setting, username is +1000 from me, we should always just log the username in any RPC we log.

  6. laanwj closed this on Mar 27, 2018

  7. laanwj referenced this in commit b648974cc3 on Mar 27, 2018
  8. PastaPastaPasta referenced this in commit b25feef8ef on Nov 1, 2020
  9. gades referenced this in commit ab07df2287 on Jun 25, 2021
  10. MarcoFalke locked this on Sep 8, 2021
  11. gades referenced this in commit 9df074be14 on Jan 28, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me