Currently when launching bitcoind with -debug=rpc the log is rather sparse, e.g. ThreadRPCServer method=validateaddres. If possible I'd like it to show the origin IP.
-
Sjors commented at 8:28 AM on January 19, 2018: member
- fanquake added the label RPC/REST/ZMQ on Jan 19, 2018
- fanquake added the label Utils/log/libs on Jan 19, 2018
-
laanwj commented at 9:51 AM on January 19, 2018: member
There's a trade-off here between useful diagnostics, and the possibility of accidentally logging sensitive information. So this should not log individual RPC arguments. But more context information would be useful.
I think it also should print the username.
-
gmaxwell commented at 9:14 AM on February 4, 2018: contributor
IP OKAY we could trigger on the logips setting, username is +1000 from me, we should always just log the username in any RPC we log.
- laanwj closed this on Mar 27, 2018
- laanwj referenced this in commit b648974cc3 on Mar 27, 2018
- PastaPastaPasta referenced this in commit b25feef8ef on Nov 1, 2020
- gades referenced this in commit ab07df2287 on Jun 25, 2021
- MarcoFalke locked this on Sep 8, 2021
- gades referenced this in commit 9df074be14 on Jan 28, 2022