Allow wallet file to be a symlink, as was the case before v0.15.0 #12228

pull mmgen wants to merge 1 commits into bitcoin:master from mmgen:wallet_symlink changing 1 files +2 −2
  1. mmgen commented at 6:30 PM on January 19, 2018: none

    No description provided.

  2. Allow wallet file to be a symlink, as was the case before v0.15.0 17cde232bf
  3. jnewbery commented at 6:34 PM on January 19, 2018: member

    NACK. Please see discussion here: #10885 (comment) for why this unintended behaviour was removed.

    In general, PRs without a description are unlikely to get much sympathy/review.

    If you need flexibility in where your wallet files are kept, you may wish to help with reviewing #11687

  4. ryanofsky commented at 6:34 PM on January 19, 2018: member

    I don't think we can do this because of concerns that storing the berkeleydb data file separately from berkeleydb log files (in database/log.*) could lead to data and funds loss. With 0.16 it will be possible to specify a -walletdir=<path> option to bitcoind that can be a symlink. Also #11687, which is not scheduled to be merged before 0.16 is branched, will restore the option for individual wallets to be symlinks (to directories).

  5. MarcoFalke commented at 6:37 PM on January 19, 2018: member

    With 0.16 it will be possible to specify a -walletdir= option to bitcoind that can be a symlink.

    I'd suggest to close this pull, then.

  6. MarcoFalke added the label Wallet on Jan 19, 2018
  7. mmgen commented at 6:43 PM on January 19, 2018: none

    With 0.16 it will be possible to specify a -walletdir= option to bitcoind that can be a symlink.

    Fine, this answers my needs (just compiled from master and tried it out) and is actually a much better solution than the symlink. Closing the PR. Thanks all for the helpful information.

  8. mmgen closed this on Jan 19, 2018

  9. mmgen deleted the branch on Jan 20, 2018
  10. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me