Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled #12246

1. 
   luke-jr commented at 3:55 am on January 23, 2018: member

   Includes #5618 (which the reasons for rejecting no longer hold true)
2. fanquake added the label Tests on Jan 23, 2018
3. laanwj assigned theuni on Feb 13, 2018
4. 
   laanwj commented at 9:27 am on February 13, 2018: member

   This change is build-system heavy, @theuni can you take a look?
5. MarcoFalke added the label Needs rebase on Jun 6, 2018
6. luke-jr force-pushed on Aug 31, 2018
7. DrahtBot removed the label Needs rebase on Aug 31, 2018
8. DrahtBot added the label Needs rebase on Sep 13, 2018
9. configure: Make it possible to build only one of bitcoin-cli or bitcoin-tx 92af71cea9
10. Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled a2a04a5abb
11. luke-jr force-pushed on Sep 13, 2018
12. DrahtBot removed the label Needs rebase on Sep 13, 2018
13. 
    DrahtBot commented at 1:27 pm on September 21, 2018: member

    • #14284 (build: Add MSVC project files for bitcoin-wallet-tool by ken2812221)
    • #14283 (WIP: Add wallet tool test by promag)
    • #13926 ([Tools] bitcoin-wallet - a tool for creating and managing wallets offline by jnewbery)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

14. 
    MarcoFalke commented at 8:42 pm on September 24, 2018: member

    utACK the bugfix. Didn’t look at the first commit.
15. 
    theuni commented at 8:30 pm on September 26, 2018: member

    Seems a bit unnecessary, but I can’t come up with a justifiable reason not to. -0 on the concept.

    The changes themselves look sane, though. utACK a2a04a5abb347d52b3ef473f7c80c3c0ffc67a2f.

16. 
    ryanofsky commented at 3:02 pm on September 27, 2018: member

    utACK a2a04a5abb347d52b3ef473f7c80c3c0ffc67a2f both commits. I think configuration options like this are useful so you can choose the components you need in a set-and-forget config step, and then use normal make, make install, and make check commands.

    A previous comment (https://github.com/bitcoin/bitcoin/pull/5618#issuecomment-88454412) seemed to suggest that these autoconf options are useless because you could alternately run commands like make -C src bitcoin-tx to selectively build components. But that’s cumbersome and unreliable and also doesn’t work with build actions like “make check” and “make install”.

    Only minor suggestion I’d make is to rephrase “Make it possible to build only one of bitcoin-cli or bitcoin-tx” commit description so it doesn’t sound like these are exclusive options. When I first saw this this PR I thought it was going to disallow building both tools at the same time.

17. MarcoFalke merged this on Sep 27, 2018
18. MarcoFalke closed this on Sep 27, 2018

    ---

19. MarcoFalke referenced this in commit b88dd7c2db on Sep 27, 2018
20. deadalnix referenced this in commit a7ca467d91 on Apr 17, 2020
21. ftrader referenced this in commit 4487044f26 on Aug 17, 2020
22. pravblockc referenced this in commit 5d1533d938 on Jul 28, 2021
23. MarcoFalke locked this on Sep 8, 2021

Contributors
luke-jr laanwj DrahtBot MarcoFalke theuni ryanofsky

Labels
Tests