Reduce scope of cs_main and cs_wallet locks in listtransactions #12330

pull promag wants to merge 1 commits into bitcoin:master from promag:2018-02-listtransactions changing 1 files +16 −13

promag commented at 2:13 AM on February 2, 2018: member
Trivial change, no behaviour change.

Benchmark done as follow:
- run with -regtest
- wallet with 5000 transactions
- measured the time spent with the lock and the total time
- times are an average of 100 listtransactions --count=... calls
--count lock (ms) total (ms) saving

10 0.2230 0.2510 11%

100 2.5150 2.8690 12%

1000 20.0320 23.3490 14%

10000 105.2070 125.5310 16%
[rpc] Reduce scope of cs_main and cs_wallet locks in listtransactions c409b1adac
fanquake added the label Wallet on Feb 2, 2018
fanquake added the label RPC/REST/ZMQ on Feb 2, 2018
promag commented at 10:21 AM on February 2, 2018: member

Updated PR description with benchmark.
devrandom commented at 4:53 AM on February 3, 2018: none

ACK https://github.com/bitcoin/bitcoin/pull/12330/commits/c409b1adac59329b78b8c48f131f8ca032988412
MarcoFalke commented at 1:36 PM on February 3, 2018: member

utACK c409b1adac59329b78b8c48f131f8ca032988412
ryanofsky commented at 8:15 PM on February 5, 2018: member

utACK c409b1adac59329b78b8c48f131f8ca032988412
sipa commented at 9:02 PM on February 5, 2018: member

utACK c409b1adac59329b78b8c48f131f8ca032988412
MarcoFalke merged this on Feb 5, 2018
MarcoFalke closed this on Feb 5, 2018
MarcoFalke referenced this in commit 2a30e67d20 on Feb 5, 2018
promag deleted the branch on Feb 5, 2018
PastaPastaPasta referenced this in commit 805daa40e1 on Apr 13, 2020
deadalnix referenced this in commit 4b993b82a1 on Jun 1, 2020
PastaPastaPasta referenced this in commit b26ae476cb on Jun 9, 2020
PastaPastaPasta referenced this in commit b49a887269 on Jun 9, 2020
PastaPastaPasta referenced this in commit dd5ac0b20a on Jun 10, 2020
PastaPastaPasta referenced this in commit a349fde5c7 on Jun 10, 2020
PastaPastaPasta referenced this in commit 88df2de9d9 on Jun 11, 2020
PastaPastaPasta referenced this in commit 1638a907e2 on Jun 11, 2020
ftrader referenced this in commit 1686399567 on Aug 17, 2020
LarryRuane referenced this in commit 9f3204de4a on Mar 4, 2021
LarryRuane referenced this in commit 25b8cdce25 on Apr 13, 2021
zkbot referenced this in commit 0e36226271 on Apr 17, 2021
DrahtBot locked this on Sep 8, 2021

`--count`	lock (ms)	total (ms)	saving
10	0.2230	0.2510	11%
100	2.5150	2.8690	12%
1000	20.0320	23.3490	14%
10000	105.2070	125.5310	16%

Contributors

Labels