getrawtransaction: time = blocktime ? #12339

Not sure if this is a bug or wanted behaviour:

getrawtransaction rpc: " \"time\" : ttt, (numeric) The transaction time in seconds since epoch (Jan 1 1970 GMT)\n"
" \"blocktime\" : ttt (numeric) The block time in seconds since epoch (Jan 1 1970 GMT)\n"

TxToJSON: entry.push_back(Pair("time", pindex->GetBlockTime())); entry.push_back(Pair("blocktime", pindex->GetBlockTime()));

If you just read the help you would think time is the time the transaction entered the mempool (as show in the getmempoolentry rpc).

Huh weird to report the same value twice. I can understand the confusion. I suppose people rely on this, so we cannot just change the API, but one could change the comment to make it clear that these are the same.

It was introduced in #1393, and it sounds like it was added because WalletTxToJSON already had time = wtx.GetTxTime().

I think we should deprecate the "blocktime" return value and improve the help text for "time"

@jnewbery I don't feel that way. WalletTxToJSON has time and blocktime, which have different values. It would be strange to have time instead of blocktime is this call. IMO we should aim for consistency in the response keys.

ah. Thanks @promag - makes sense.

Then yes - updating the help text seems sufficient.

updating the help text seems sufficient.

For sure!

Fixed in #14981.