During initial sync, chain download pauses if peer goes away #1234

1. 
   gmaxwell commented at 10:39 am on May 9, 2012: contributor

   This is a well know behavior that ought to be fixed, but I don’t think anyone has opened an issue for it yet.

   During the initial syncup if the peer we’re pulling from goes away the download will stop until the next block triggers the process. This is suboptimal and results in bitcoin-is-stuck complaints on long blocks or users needlessly restarting their client or reinstalling Bitcoin.

2. 
   rebroad commented at 2:14 pm on May 12, 2012: contributor

   Issue #1053 was kinda this, but maybe too specific :)
3. 
   rebroad commented at 2:29 pm on May 12, 2012: contributor

   This just needs a line adding such as pfrom->AskedForBlocks = true along with nAskedForBlocks++, which then can nAskedForBlocks– when that node disconnects… so the getblocks fires off again (maybe even move that code outside of the strCommand == “version”, so that already connected nodes can fire off the getblocks).

   I’ve already coded this in my fork, but not gotten around to neatening it into a commit and pull requesting it. Will do asap (unless someone else does first), in fact, doing this now.

4. rebroad referenced this in commit 8e2904dd40 on May 12, 2012
5. rebroad referenced this in commit 6fba82044d on May 12, 2012
6. rebroad referenced this in commit db4eb7fe5b on May 12, 2012
7. rebroad referenced this in commit 836e0d07af on May 15, 2012
8. rebroad referenced this in commit 8eb094cd3c on May 17, 2012
9. rebroad referenced this in commit 2a0a591d75 on May 17, 2012
10. rebroad referenced this in commit 81cc784fa7 on May 17, 2012
11. rebroad referenced this in commit 08d26e5d67 on May 17, 2012
12. rebroad referenced this in commit c36298da9c on May 17, 2012
13. rebroad referenced this in commit c7abd9a50f on May 17, 2012
14. rebroad referenced this in commit 58f2a42bb9 on May 18, 2012
15. rebroad referenced this in commit 0d42e592a1 on May 22, 2012
16. rebroad referenced this in commit 886461f3ca on May 25, 2012
17. rebroad referenced this in commit bd608e7f28 on May 29, 2012
18. rebroad referenced this in commit f71afd2002 on May 29, 2012
19. rebroad referenced this in commit e8104686c0 on Jun 5, 2012
20. rebroad referenced this in commit b62a37e873 on Jun 14, 2012
21. rebroad referenced this in commit 9aaa77e427 on Jun 14, 2012
22. rebroad referenced this in commit 9543ca35ca on Jun 14, 2012
23. rebroad referenced this in commit 05d1d970a9 on Sep 6, 2012
24. rebroad referenced this in commit 8ce572c8ad on Sep 6, 2012
25. rebroad referenced this in commit 3d2aea0573 on Dec 18, 2012
26. rebroad referenced this in commit bbd9c1c373 on Dec 20, 2012
27. 
    rebroad commented at 7:31 pm on January 13, 2013: contributor

    I don’t understand why it’s taking so long to fix this rather simple issue….
28. rebroad referenced this in commit f4e09a830d on Mar 17, 2013
29. rebroad referenced this in commit b8fd133f51 on Mar 21, 2013
30. rebroad referenced this in commit 2ea69ebe2b on Mar 24, 2013
31. rebroad referenced this in commit 9fc4c03556 on Mar 24, 2013
32. rebroad referenced this in commit 0fafb26962 on Apr 2, 2013
33. rebroad referenced this in commit e18c4a169d on Apr 16, 2013
34. 
    sipa commented at 11:27 pm on April 23, 2013: member

    Closed by #2461
35. sipa closed this on Apr 23, 2013

    ---

36. BitsInMyBlood referenced this in commit f927ee1aa8 on Oct 28, 2017
37. laanwj referenced this in commit c95832da87 on Nov 1, 2017
38. suprnurd referenced this in commit 7815f6e32e on Dec 5, 2017
39. HashUnlimited referenced this in commit ba2535f16b on Mar 13, 2018
40. lateminer referenced this in commit 22440994d6 on Jan 22, 2019
41. lateminer referenced this in commit 2d6d48c74c on Jan 10, 2020
42. lateminer referenced this in commit 51e7ea2a0a on Jan 10, 2020
43. Bushstar referenced this in commit ce381d0826 on Apr 8, 2020
44. dexX7 referenced this in commit ad1804f69d on Aug 10, 2021
45. laanwj referenced this in commit 9cfe7d1abe on Sep 1, 2021
46. DrahtBot locked this on Sep 8, 2021

Contributors
gmaxwell rebroad sipa

Labels
Bug