Kill warning from unavoidable signed/unsigned comparison in bitcoinrpc.cpp. #1237

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:master changing 1 files +1 −1

gmaxwell commented at 11:21 AM on May 9, 2012: contributor

No description provided.
Kill warning from unavoidable signed/unsigned comparison in bitcoinrpc.cpp. d285c7bf2c
Diapolo commented at 12:42 PM on May 9, 2012: none

I re-added the "-Wno-invalid-offsetof -Wno-sign-compare" switches to my local build environment, as it showed me ~150 sign/offset warnings. Am I the only one who observed this?
gmaxwell commented at 1:32 PM on May 9, 2012: contributor

@Diapolo Yes. :) (are you actually current with master? What GCC version? With 4.7.0 we're clean for me (save a complaint about ignoring a fwrite return value)
Diapolo commented at 1:44 PM on May 9, 2012: none

Using current master with own mods I'm testing, but the Warnings arr all over the place. Using Qt Creator, which is bundled with MinGW - gcc version 4.4.0 (GCC). I have to say I don't compile bitcoind.exe, but Bitcoin-Qt.exe.
sipa commented at 1:50 PM on May 9, 2012: member

I believe the windows version still causes many warnings in the boost compile.
jgarzik referenced this in commit 9d9aae0396 on May 9, 2012
jgarzik merged this on May 9, 2012
jgarzik closed this on May 9, 2012
coblee referenced this in commit f11d49e5ce on Jul 17, 2012
suprnurd referenced this in commit 7544a70e1b on Dec 5, 2017
lateminer referenced this in commit 5922668a74 on Jan 22, 2019
lateminer referenced this in commit 51e7ea2a0a on Jan 10, 2020
DrahtBot locked this on Sep 8, 2021

Contributors