Fix ignoring tx data requests when fPauseSend is set on a peer #12392

1. 
   TheBlueMatt commented at 11:34 pm on February 8, 2018: member

   This resolves a bug introduced in 66aa1d58a158991a8014a91335b5bc9c00062f56 where, if when responding to a series of transaction requests in a getdata we hit the send buffer limit and set fPauseSend, we will skip one transaction per call to ProcessGetData.

   Bug found by Cory Fields (@theuni).

   Probably worth slipping into 0.16 :/.

2. Fix ignoring tx data requests when fPauseSend is set on a peer

   This resolves a bug introduced in
   66aa1d58a158991a8014a91335b5bc9c00062f56 where, if when responding
   to a series of transaction requests in a getdata we hit the send
   buffer limit and set fPauseSend, we will skip one transaction per
   call to ProcessGetData.
   
   Bug found by Cory Fields (@theuni).

   c4af738763
3. fanquake added the label P2P on Feb 9, 2018
4. fanquake added this to the milestone 0.16.0 on Feb 9, 2018
5. 
   theuni commented at 2:37 am on February 9, 2018: member

   utACK c4af7387634765d254d1432746385cf35917d367
6. in src/net_processing.cpp:1231 in c4af738763

   1225@@ -1226,10 +1226,10 @@ void static ProcessGetData(CNode* pfrom, const Consensus::Params& consensusParam
   1226         }
   1227     } // release cs_main
   1228 
   1229-    if (it != pfrom->vRecvGetData.end()) {
   1230+    if (it != pfrom->vRecvGetData.end() && !pfrom->fPauseSend) {
   1231         const CInv &inv = *it;
   1232-        it++;
   

   ---

   ---

   

   promag commented at 12:48 pm on February 9, 2018:

   So inv is being discarded in master?

   ---

   

   TheBlueMatt commented at 3:04 pm on February 9, 2018:

   Yes. But only on master, luckily @theuni caught this pre-release.
7. 
   jnewbery commented at 3:48 pm on February 9, 2018: member

   utACK c4af7387634765d254d1432746385cf35917d367
8. 
   jonasschnelli commented at 10:07 am on February 10, 2018: contributor

   utACK c4af7387634765d254d1432746385cf35917d367
9. MarcoFalke added the label Needs backport on Feb 10, 2018
10. 
    jamesob commented at 7:59 pm on February 10, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/12392/commits/c4af7387634765d254d1432746385cf35917d367
11. laanwj merged this on Feb 12, 2018
12. laanwj closed this on Feb 12, 2018

    ---

13. laanwj referenced this in commit a8cbbdb07a on Feb 12, 2018
14. laanwj referenced this in commit 0f616517e1 on Feb 12, 2018
15. MarcoFalke removed the label Needs backport on Feb 12, 2018
16. HashUnlimited referenced this in commit fda923aefc on Mar 16, 2018
17. ccebrecos referenced this in commit a86205c1ad on Sep 14, 2018
18. codablock referenced this in commit bb0e326081 on Dec 6, 2019
19. codablock referenced this in commit 697d289ebc on Dec 6, 2019
20. codablock referenced this in commit e69c6c3207 on Dec 6, 2019
21. MIPPL referenced this in commit 34851a0463 on Jan 1, 2020
22. FornaxA referenced this in commit b0a9505bcd on Jul 6, 2020
23. DrahtBot locked this on Sep 8, 2021

Contributors
TheBlueMatt theuni promag jnewbery jonasschnelli jamesob

Labels
P2P

Milestone
0.16.0