Fix a-vs-an typos #12393

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:a-vs-an-typos changing 10 files +12 −12

practicalswift commented at 9:10 AM on February 9, 2018: contributor

Fix a-vs-an typos.
fanquake added the label Docs on Feb 9, 2018

in src/script/ismine.h:32 in 0f7b59008e outdated

  28 | @@ -29,7 +29,7 @@ enum isminetype
  29 |  typedef uint8_t isminefilter;
  30 |  
  31 |  /* isInvalid becomes true when the script is found invalid by consensus or policy. This will terminate the recursion
  32 | - * and return a ISMINE_NO immediately, as an invalid script should never be considered as "mine". This is needed as
  33 | + * and return an ISMINE_NO immediately, as an invalid script should never be considered as "mine". This is needed as

promag commented at 12:26 PM on February 9, 2018:

Remove an?

practicalswift commented at 12:45 PM on February 9, 2018:

Thanks! Fixed!

promag commented at 12:28 PM on February 9, 2018: member

ACK.
practicalswift force-pushed on Feb 9, 2018
practicalswift force-pushed on Feb 9, 2018
randolf changes_requested
randolf commented at 3:40 PM on February 9, 2018: contributor

ACK for 11 out of 12 changes...

NACK for 1 change in src/reverselock.h because the original "An RAII-style" is actually correct since acronyms tend to be read out letter-by-letter and the word "An" flows more easily and correctly when reading out loud.
practicalswift commented at 4:06 PM on February 9, 2018: contributor

@randolf Good point about RAII. Fixed. Please re-review :-)
randolf commented at 4:29 PM on February 9, 2018: contributor

@practicalswift I don't see the fix yet, but perhaps GitHub just needs some time to synchronize. I'll check again later and approve once the fix appears. Thanks for the quick turn-around.
randolf commented at 1:20 AM on February 10, 2018: contributor

@practicalswift I just asked some other developers about this, and they suspect that you may need to "push" your changes so that they'll appear here.
jonasschnelli commented at 10:04 AM on February 10, 2018: contributor

Meh ACK f88597ad01eb8e6b872f5fc6a0bb04b17689542c
practicalswift force-pushed on Feb 10, 2018
practicalswift commented at 3:12 PM on February 10, 2018: contributor

@randolf Oh, I forgot to push after changing. Thanks for letting me know! Please re-review :-)
randolf approved
MarcoFalke commented at 4:39 PM on February 10, 2018: member

Travis fails with FAIL: subtree directory was touched without subtree merge
Fix a-vs-an typos 11376b5583
practicalswift force-pushed on Feb 11, 2018
practicalswift commented at 9:49 AM on February 11, 2018: contributor

Removed the change to src/univalue/ since that one should be reported upstream instead.

Please re-review :-)
randolf approved
luke-jr approved
luke-jr commented at 3:17 AM on February 12, 2018: member

utACK
laanwj merged this on Feb 12, 2018
laanwj closed this on Feb 12, 2018
laanwj referenced this in commit 108af52ef7 on Feb 12, 2018
braydonf referenced this in commit e866da81ee on Feb 2, 2019
braydonf referenced this in commit efa78100e0 on Feb 2, 2019
tuxcanfly referenced this in commit 586fef8219 on Apr 19, 2019
PastaPastaPasta referenced this in commit 4f47be81e5 on Jun 13, 2020
PastaPastaPasta referenced this in commit 0b84d71baf on Jun 13, 2020
PastaPastaPasta referenced this in commit 1c59753d37 on Jun 14, 2020
PastaPastaPasta referenced this in commit 541bce443f on Jun 17, 2020
PastaPastaPasta referenced this in commit 9d22d9fdea on Jun 17, 2020
PastaPastaPasta referenced this in commit 2788e0180e on Jun 17, 2020
PastaPastaPasta referenced this in commit 9b0c1f7733 on Jun 17, 2020
practicalswift deleted the branch on Apr 10, 2021
gades referenced this in commit b251781237 on Mar 8, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels