Output type is used by the wallet when generating addresses or transactions with change, thus it should be a member of CWallet.
Moreover, in light of multiwallet, it makes sense to prepare for per-wallet attributes instead of for-all-wallets globals.
utACK fab8778.
How do you plan to have different types for different wallets?
4019+ if (walletInstance->m_change_type == OutputType::NONE && !gArgs.GetArg("-changetype", "").empty()) {
4020+ InitError(strprintf("Unknown change type '%s'", gArgs.GetArg("-changetype", "")));
4021+ return nullptr;
4022+ }
4023+
4024+
utACK https://github.com/bitcoin/bitcoin/pull/12408/commits/fa9d869d0beec2e6b87c4b88d7226e78864f9e10
I echo @promag ’s question. Out of scope for now, but would be good to know.
803@@ -808,6 +804,8 @@ class CWallet final : public CCryptoKeyStore, public CValidationInterface
804
805 void SetNull()
806 {
807+ m_address_type = OutputType::NONE;
DEFAULT, there is use case NONE change type (change_type = g_change_type != OUTPUT_TYPE_NONE ? g_change_type : g_address_type).
utACK fa9d869d0beec2e6b87c4b88d7226e78864f9e10
Just a suggestion, but I think switching to m_default_address_type instead of m_address_type and GetDefaultAddressType instead of GetWalletAddressType (and similarly for change) might be a little more clear and consistent.
How do you plan to have different types for different wallets?
I think the answer would depend on what the use case for per-wallet output types is (assuming there is a use case).
If the address/change types for a wallet are supposed to be stable, they should probably be determined from the database, either by being stored explicitly, or by being derived from the wallet version number. In this case the output types should be persistent and controllable by RPC.
Alternately, if the output types should just be runtime settings, we could follow sqlite’s example and allow specifying per-file options with uri query parameters, for example: "-wallet=name?addresstype=bech32".
switching to m_default_address_type instead of m_address_type and GetDefaultAddressType instead of GetWalletAddressType @ryanofsky 👍
OutputType::DEFAULT.