Fix rescan test failure due to unset g_address_type, g_change_type #12424

1. 
   ryanofsky commented at 5:40 pm on February 13, 2018: member

   New global variables were introduced in #11403 and not setting them causes:

   0test_bitcoin: wallet/wallet.cpp:4259: CTxDestination GetDestinationForKey(const CPubKey&, OutputType): Assertion `false' failed.
   1unknown location(0): fatal error in "importwallet_rescan": signal: SIGABRT (application abort requested)
   

   It’s possible to reproduce the failure reliably by running:

   0src/test/test_bitcoin --log_level=test_suite --run_test=wallet_tests/importwallet_rescan
   

   Failures happen nondeterministically because boost test framework doesn’t run tests in a specified order, and tests that run previously can set the global variables and mask the bug.

   This is similar to bug #12150. Example travis failure is https://travis-ci.org/bitcoin/bitcoin/jobs/340642010

2. Fix rescan test failure due to unset g_address_type, g_change_type

   New global variables were introduced in #11403 and not setting them causes:
   
       test_bitcoin: wallet/wallet.cpp:4259: CTxDestination GetDestinationForKey(const CPubKey&, OutputType): Assertion `false' failed.
       unknown location(0): fatal error in "importwallet_rescan": signal: SIGABRT (application abort requested)
   
   It's possible to reproduce the failure reliably by running:
   
       src/test/test_bitcoin --log_level=test_suite --run_test=wallet_tests/importwallet_rescan
   
   Failures happen nondeterministically because boost test framework doesn't run
   tests in a specified order, and tests that run previously can set the global
   variables and mask the bug.

   b7f6002ed5
3. 
   promag commented at 5:45 pm on February 13, 2018: member

   What about #12408?
4. 
   ryanofsky commented at 5:48 pm on February 13, 2018: member

   What about #12408?

   It’s a good change that would probably also fix the problem. This is just a direct fix for the travis failures I’m seeing right now.

5. 
   MarcoFalke commented at 7:35 pm on February 13, 2018: member

   utACK. Seems like a quick fix for all the Travis failures

   On Feb 13, 2018 12:49 PM, “Russell Yanofsky” notifications@github.com wrote:

   What about #12408 https://github.com/bitcoin/bitcoin/pull/12408?

   It’s a good change that would probably also fix the problem. This is just a direct fix for the travis failures I’m seeing right now.

   — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/12424#issuecomment-365347061, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv9YzYOJpyAIqzAbDRGkGC6gb2etCks5tUcslgaJpZM4SEIwd .

6. MarcoFalke added the label Tests on Feb 13, 2018
7. 
   promag commented at 8:02 pm on February 13, 2018: member

   In that case :+1:
8. 
   sipa commented at 1:24 am on February 14, 2018: member

   utACK b7f6002ed5d12b461eb56b768d06f2468cd0c12e.

   Going to merge this quickly to avoid further Travis failures.

9. sipa merged this on Feb 14, 2018
10. sipa closed this on Feb 14, 2018

    ---

11. sipa referenced this in commit 252ae7111c on Feb 14, 2018
12. MarcoFalke added this to the milestone 0.16.0 on Feb 14, 2018
13. MarcoFalke added the label Needs backport on Feb 14, 2018
14. 
    MarcoFalke commented at 3:32 am on February 14, 2018: member

    @laanwj Can you backport this to the 16 branch, please?
15. laanwj referenced this in commit ff44101e8d on Feb 14, 2018
16. 
    laanwj commented at 11:32 am on February 14, 2018: member

    @MarcoFalke done
17. MarcoFalke removed the label Needs backport on Feb 14, 2018
18. MarcoFalke referenced this in commit 6012f1caf7 on Mar 3, 2018
19. HashUnlimited referenced this in commit 2f20e65301 on Mar 16, 2018
20. ccebrecos referenced this in commit 20f290880c on Sep 14, 2018
21. PastaPastaPasta referenced this in commit a4c7a60f18 on Jun 27, 2021
22. MarcoFalke locked this on Sep 8, 2021

Contributors
ryanofsky promag MarcoFalke sipa laanwj

Labels
Tests

Milestone
0.16.0