This prevents segfaults (or errors when running qt in valgrind)
Conditional jump or move depends on uninitialised value(s)
WalletModel::checkBalanceChanged() (walletmodel.cpp:156)
qt: Initialize members in WalletModel #12426
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1802-qtInitializeMembersWalletModel changing 1 files +1 −0-
MarcoFalke commented at 9:03 PM on February 13, 2018: member
-
qt: Initialize members in WalletModel fa27623edb
- MarcoFalke added the label GUI on Feb 13, 2018
-
ryanofsky commented at 11:00 PM on February 13, 2018: member
utACK, but it would be better to initialize members inline the future to make these bugs more obvious:
CAmount cachedWatchOnlyBalance = 0; -
laanwj commented at 3:18 PM on February 14, 2018: member
utACK https://github.com/bitcoin/bitcoin/pull/12426/commits/fa27623edbe7530d667e05d513066d1bd5339f41, good catch.
utACK, but it would be better to initialize members inline the future to make these bugs more obvious:
Indeed, if that's consistently done it's much easier to see missing ones. But would have to move all of the initializers at the same time then.
- laanwj merged this on Feb 15, 2018
- laanwj closed this on Feb 15, 2018
- laanwj referenced this in commit bfa39114e2 on Feb 15, 2018
- MarcoFalke deleted the branch on Feb 16, 2018
- laanwj referenced this in commit 21e2670de3 on Mar 5, 2018
- laanwj referenced this in commit 3f12515199 on Jan 9, 2019
- laanwj referenced this in commit 070eaf7fe5 on Jan 14, 2019
- PastaPastaPasta referenced this in commit 45beb63cf2 on Jun 10, 2020
- PastaPastaPasta referenced this in commit 967a681da8 on Jun 12, 2020
- PastaPastaPasta referenced this in commit df862d3f25 on Jun 13, 2020
- PastaPastaPasta referenced this in commit b541a28a74 on Jun 13, 2020
- PastaPastaPasta referenced this in commit b00e7ac69e on Jun 13, 2020
- PastaPastaPasta referenced this in commit 54f9a9fd80 on Jun 14, 2020
- PastaPastaPasta referenced this in commit 7e8d72c862 on Jun 14, 2020
- PastaPastaPasta referenced this in commit 28879fc052 on Jun 14, 2020
- PastaPastaPasta referenced this in commit fd9a0e8ded on Jun 17, 2020
- PastaPastaPasta referenced this in commit 1cfb7af4ff on Jun 17, 2020
- PastaPastaPasta referenced this in commit e1a9807c5c on Jun 17, 2020
- PastaPastaPasta referenced this in commit 145f6798a3 on Jun 17, 2020
- pravblockc referenced this in commit a7a5a1c067 on Aug 9, 2021
- pravblockc referenced this in commit 8e21d90eed on Aug 11, 2021
- pravblockc referenced this in commit 95d588e9b4 on Aug 11, 2021
- 5tefan referenced this in commit bfba8f2211 on Aug 12, 2021
- MarcoFalke locked this on Sep 8, 2021
