__repr__ returns string, so don't mix it with byte strings.
This fixes
TypeError: %b requires a bytes-like object, or an object that implements __bytes__, not 'str'
qa: Fix python TypeError in script.py #12475
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1802-qaPythonSyntax changing 1 files +1 −3-
MarcoFalke commented at 12:11 AM on February 18, 2018: member
- MarcoFalke added the label Tests on Feb 18, 2018
-
conscott commented at 5:44 PM on February 18, 2018: contributor
ACK fa82cacf601acf7f92b51a6f870cb4f6bbfe92db
- fanquake changes_requested
-
fanquake commented at 2:57 AM on February 19, 2018: member
Is this comment above now out of date? "For Python3 compatibility add b before strings so testcases don't need to change"
- MarcoFalke force-pushed on Feb 19, 2018
-
qa: Fix python TypeError in script.py fa41d68a2e
- MarcoFalke force-pushed on Feb 19, 2018
-
MarcoFalke commented at 4:43 AM on February 19, 2018: member
Removed comment
On Feb 18, 2018 21:57, "fanquake" notifications@github.com wrote:
@fanquake requested changes on this pull request.
Is this comment above now out of date? "For Python3 compatibility add b before strings so testcases don't need to change"
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/12475#pullrequestreview-97432575, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmv1_0JF7fqKhjCNDeB7IQJdHF0R1Aks5tWOMzgaJpZM4SJg99 .
-
fanquake commented at 5:14 AM on February 19, 2018: member
utACK fa41d68
-
laanwj commented at 4:32 PM on March 5, 2018: member
utACK fa41d68a2
- laanwj merged this on Mar 5, 2018
- laanwj closed this on Mar 5, 2018
- laanwj referenced this in commit 07d2d2a21c on Mar 5, 2018
- MarcoFalke deleted the branch on Mar 14, 2018
- MarcoFalke referenced this in commit 70a2118f57 on Apr 20, 2018
- MarcoFalke referenced this in commit 41c29f6d1d on Apr 20, 2018
- HashUnlimited referenced this in commit ed900d454e on May 13, 2018
- PastaPastaPasta referenced this in commit b8f722cc39 on Mar 14, 2020
- PastaPastaPasta referenced this in commit 551e3eaceb on Mar 19, 2020
- PastaPastaPasta referenced this in commit 572c96eb33 on Mar 21, 2020
- PastaPastaPasta referenced this in commit 62bbabb6ac on Mar 24, 2020
- ckti referenced this in commit 2766a60cc3 on Mar 28, 2021
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels