The binary of 50 * (10 ** 8) is "100101010000001011111001000000000", which length is 33-bit, it can only be right shifted 32 times, any time larger than 32 will produce 0 and is pointless.
Mining: The max number of halvings should be 32 #12485
pull bitnitdit wants to merge 1 commits into bitcoin:master from bitnitdit:max_halvings changing 2 files +4 −3-
bitnitdit commented at 1:16 AM on February 20, 2018: none
-
5722d0f8e8
Mining: The max number of halvings should be 32
The binary of 50 * (10 ** 8) is "100101010000001011111001000000000", which length is 33-bit, it can only be right shifted 32 times, any time larger than 32 will produce 0 and is pointless.
-
- MarcoFalke added the label Refactoring on Feb 20, 2018
-
luke-jr commented at 1:55 AM on February 20, 2018: member
I don't think we need a subtle assumption about the initial subsidy here... The cost to be flexible is minuscule.
-
MarcoFalke commented at 2:29 AM on February 20, 2018: member
Tend to agree with @luke-jr. Do you have benchmarks, that show this is a significant improvement?
-
sipa commented at 2:44 AM on February 20, 2018: member
NAK, this doesn't clarify anything.
-
MarcoFalke commented at 3:05 AM on February 20, 2018: member
There seems to be disagreement about the changes. Closing for now.
- MarcoFalke closed this on Feb 20, 2018
-
bitnitdit commented at 12:01 PM on February 20, 2018: none
@fanquake Thank you very much for the reference. @luke-jr @MarcoFalke @sipa Thank you all very much for the review. Thanks!
- bitnitdit deleted the branch on Feb 20, 2018
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels