GUI: file->receiving addresses->New only generates non-bech32 addresses, even if the box "generate bech32" is ticked in the main window #12520

issue notsureif opened this issue on February 23, 2018
  1. notsureif commented at 8:10 PM on February 23, 2018: none

    As the title says: GUI: file->receiving addresses->New only generates non-bech32 addresses, even if the box "generate bech32" is ticked in the main window

    Suggestion: put a tick box "generate bech32 addresses" in the "receiving addresses: window as well

    <!-- This issue tracker is only for technical issues related to Bitcoin Core. General bitcoin questions and/or support requests are best directed to the Bitcoin StackExchange at https://bitcoin.stackexchange.com. For reporting security issues, please read instructions at https://bitcoincore.org/en/contact/. If the node is "stuck" during sync or giving "block checksum mismatch" errors, please ensure your hardware is stable by running memtest and observe CPU temperature with a load-test tool such as linpack before creating an issue! -->

    <!-- Describe the issue -->

    <!--- What behavior did you expect? -->

    <!--- What was the actual behavior (provide screenshots if the issue is GUI-related)? -->

    <!--- How reliably can you reproduce the issue, what are the steps to do so? -->

    <!-- What version of Bitcoin Core are you using, where did you get it (website, self-compiled, etc)? -->

    <!-- What type of machine are you observing the error on (OS/CPU and disk type)? -->

    <!-- Any extra information that might be useful in the debugging process. -->

    <!--- This is normally the contents of a `debug.log` or `config.log` file. Raw text or a link to a pastebin type site are preferred. -->

  2. promag commented at 8:39 PM on February 23, 2018: member

    To generate bech32 addresses by default launch with -addresstype=bech32.

    even if the box "generate bech32" is ticked in the main window

    That checkbox isn't a global setting, for that there is #11937.

  3. fanquake added the label GUI on Feb 24, 2018
  4. Sjors commented at 8:39 PM on March 15, 2018: member

    Concept ACK for adding a bech32 checkbox to that dialog:

    schermafbeelding 2018-03-15 om 16 38 14

    However, I'm not going to write that PR :-)

  5. jonasschnelli commented at 4:34 AM on March 19, 2018: contributor

    Another way would be just removing the "New" button in the address book since the address book is probably not something that should be there in the long because it leads to address reuse.

    Also, there should not be two ways how to generate an address in the GUI.

  6. laanwj referenced this in commit e476826338 on Mar 20, 2018
  7. TheKogs commented at 6:33 AM on March 26, 2018: none

    Actually I am not happy with removing the New button in the address book. It broke the way I work with the qt client. I'm usually working with the address book to create new addresses without requesting a new payment in the "Receive" tab. This is not possible anymore.

    I already implemented the new checkbox in the New Address Gui. Just before I wanted to create the pull request, I merged the last changes from bitcoin/master branch and found out that my change did not compile anymore as the editaddressdialog.cpp don't support creating a new receiving address any more.

    I will try to change my way how I work, but for now I don't see a comfortable way to have an overview of my addresses and can create new ones in one single gui.

    Is there any chance to get this feature back?

  8. Sjors commented at 2:35 PM on March 26, 2018: member

    a comfortable way to have an overview of my addresses and can create new ones in one single gui

    Doesn't the Receive tab offer that?

  9. TheKogs commented at 4:44 AM on March 27, 2018: none

    I was playing around a bit with the Receive tab. If I would have worked with the Receive tab from beginning I think it would be OK. But as I did not use it before, I'm missing the already created addresses in the list. I only see them in the address book. One advantage I can see in the Receive tab is that it's possible to remove some entries from the list. The address book keeps also unwanted addresses which makes it quite big after time.

    Working with the address book was also not perfect for me as I was also missing some things like showing current balance of the addresses (also not available in the Receive tab directly - only in the Coin Control dialog), so I will think of a solution which fits my needs best and then maybe create a proposal to see if there is anyone who might like my ideas.

    I will stop here as it starts to get off topic and create a new issue when I have a better idea.

  10. notsureif commented at 11:09 AM on March 27, 2018: none

    I think I should close this, as the merge by jonasschnelli removes the issue in the form it's stated.

  11. notsureif closed this on Mar 27, 2018

  12. PastaPastaPasta referenced this in commit 5611388774 on Jun 10, 2020
  13. PastaPastaPasta referenced this in commit 0ea90aabc0 on Jun 13, 2020
  14. PastaPastaPasta referenced this in commit 71b88578c0 on Jun 13, 2020
  15. PastaPastaPasta referenced this in commit 6e74920366 on Jun 13, 2020
  16. PastaPastaPasta referenced this in commit d577a19c00 on Jun 17, 2020
  17. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me