Qt: remove "new" button during receive-mode in addressbook #12721

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2018/03/addr_new_btn changing 3 files +8 −11

jonasschnelli commented at 5:21 AM on March 19, 2018: contributor

There are currently two ways how to generate new receiving addresses in the GUI (which leads to code duplication or required refactoring, see #12520).

Since the address-book is probably something that should be removed in the long run, suppressing the new-button in receive-mode could be a first step in deprecating the address book.

With this PR, users can still edit existing receiving address book entries and they can still create new sending address book entries.
Qt: remove "new" button during receive-mode in addressbook d843db7733
jonasschnelli added the label GUI on Mar 19, 2018
laanwj commented at 2:50 PM on March 19, 2018: member

Concept ACK - I think this makes sense, yes. The receiving tab is the obvious way to create receiving addresses, the other is just a leftover of how things used to be. This might need mention in the release notes.
MarcoFalke commented at 4:12 PM on March 19, 2018: member

utACK d843db7733135e2a93eaff21a03d9a025fceabd6. (I don't think this needs mention in the release notes.)
fanquake commented at 6:23 AM on March 20, 2018: member

Concept ACK <img width="754" alt="master" src="https://user-images.githubusercontent.com/863730/37638898-2316fa66-2c4a-11e8-803e-6111e6ce9b84.png"> <img width="751" alt="12721" src="https://user-images.githubusercontent.com/863730/37638905-29d30d04-2c4a-11e8-86d6-b4026ba6ffec.png">
laanwj merged this on Mar 20, 2018
laanwj closed this on Mar 20, 2018
laanwj referenced this in commit e476826338 on Mar 20, 2018
promag commented at 4:19 PM on March 20, 2018: member

Tested ACK d843db7.
Fabcien referenced this in commit 0832c3db38 on Aug 30, 2019
PastaPastaPasta referenced this in commit 5611388774 on Jun 10, 2020
PastaPastaPasta referenced this in commit 0ea90aabc0 on Jun 13, 2020
PastaPastaPasta referenced this in commit 71b88578c0 on Jun 13, 2020
PastaPastaPasta referenced this in commit 6e74920366 on Jun 13, 2020
PastaPastaPasta referenced this in commit d577a19c00 on Jun 17, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#12520 GUI: file->receiving addresses->New only generates non-bech32 addresses, even if the box "generate bech32" is ticked in the main window