tests: List skipped flake8 warnings (rather than listing enabled warnings) #12534

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:lint-python-invert changing 1 files +55 −55

practicalswift commented at 10:44 AM on February 25, 2018: contributor
Specify skipped flake8 warnings (rather than enabled warnings).

Rationale:
- By listing the skipped warnings we get a list of violations to fix in order to reach PEP8 compliance.
- Keeping track of violations over time is easier than keeping track of non-violations.
- The list of skipped warnings is shorter than the list of enabled warnings.
tests: Specify skipped flake8 warnings (rather than enabled warnings) c92997ed0c
practicalswift renamed this:
~~tests: Specify skipped flake8 warnings (rather than enabled warnings)~~
tests: List skipped flake8 warnings (rather than listing enabled warnings)
on Feb 25, 2018
fanquake added the label Tests on Feb 25, 2018
MarcoFalke commented at 3:14 PM on February 25, 2018: member

How likely is it that new warnings get added to flake8, as that might randomly break the build?
ho1to approved
practicalswift commented at 8:03 AM on February 26, 2018: contributor

@MarcoFalke I've been running flake8 in a CI setting for many years now and I've never encountered that problem so I think it should be highly unlikely. However, if it turns out to be a problem then we can solve it by just pinning the flake8 version :-)
laanwj commented at 5:34 PM on March 5, 2018: member

TBH. I prefer listing the checks that are enabled. Now we can browse the file and have a list of enabled checks, in absence of total knowledge about the linting tool this gives more information what your code needs to conform to.
practicalswift commented at 2:31 PM on March 25, 2018: contributor

Seems like we have a consensus NACK here. Closing.
practicalswift closed this on Mar 25, 2018
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels