test: Use wait_until to ensure ping goes out #12545

1. 
   Empact commented at 7:34 pm on February 26, 2018: member

   Intermittent failure evident here: https://travis-ci.org/bitcoin/bitcoin/jobs/344021180
2. 
   MarcoFalke commented at 8:58 pm on February 26, 2018: member

   Could we instead get rid of the time.sleep with an arbitrary argument? That is just terrible practice. If it is necessary to wait on some predicate, you might use the wait_until helper function.
3. 
   Empact commented at 9:32 pm on February 26, 2018: member

   Sounds good to me, hadn’t seen wait_until
4. test: Use wait_until to ensure ping goes out

   Intermittent failure evident here:
   https://travis-ci.org/bitcoin/bitcoin/jobs/344021180

   0eb84f30d8
5. Empact force-pushed on Feb 26, 2018
6. Empact renamed this:
   test: Extend wait time by .1 seconds to ensure ping goes out
   test: Use wait_until to ensure ping goes out
   on Feb 26, 2018
7. 
   Empact commented at 10:02 pm on February 26, 2018: member

   Switched to using wait_until here. There are a few other uses of time.sleep for this sort of thing. I’ll switch them over in another PR.
8. fanquake added the label Tests on Feb 27, 2018
9. 
   conscott commented at 2:03 pm on February 27, 2018: contributor

   Tested 0eb84f30d80847b7392ad42b2d916eaf5923a63c ACK.

   I also saw this issue last week, thanks for fix.

10. laanwj assigned MarcoFalke on Mar 6, 2018
11. achow101 referenced this in commit 66e91420ab on Mar 13, 2018
12. MarcoFalke merged this on Mar 13, 2018
13. MarcoFalke closed this on Mar 13, 2018

    ---

14. 
    MarcoFalke commented at 0:55 am on March 13, 2018: member

    utACK 0eb84f30d8
15. Empact deleted the branch on Mar 19, 2018
16. laanwj referenced this in commit 93634f296e on Mar 19, 2018
17. MarcoFalke referenced this in commit 7269e6354d on Apr 20, 2018
18. MarcoFalke referenced this in commit 1286f3e49a on Apr 20, 2018
19. HashUnlimited referenced this in commit 3af640e8be on May 13, 2018
20. ccebrecos referenced this in commit a94c2ab73f on Sep 14, 2018
21. codablock referenced this in commit 1d8eb903ad on Oct 22, 2019
22. barrystyle referenced this in commit 84b0cfe6ed on Jan 22, 2020
23. PastaPastaPasta referenced this in commit bebfc238a4 on Mar 14, 2020
24. PastaPastaPasta referenced this in commit 5c7c972bcc on Mar 19, 2020
25. PastaPastaPasta referenced this in commit b40bf71a85 on Mar 21, 2020
26. PastaPastaPasta referenced this in commit 8bf0a5c3c7 on Mar 24, 2020
27. ckti referenced this in commit 994fac81b6 on Mar 28, 2021
28. MarcoFalke locked this on Sep 8, 2021

Contributors
Empact MarcoFalke conscott

Labels
Tests