Pull-Requests
pull
Add header-sensitive size checking via CPubKey::ValidSize, and prefer key/sig size const references
#12319
Empact on January 31, 2018 Refactoring
Empact on January 31, 2018 Refactoring
pull
Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt
#12357
Empact on February 5, 2018 RefactoringValidation
Empact on February 5, 2018 RefactoringValidation
pull
Fix bip68 sequence test to reflect updated rpc error message
#12455
Empact on February 16, 2018 Tests
Empact on February 16, 2018 Tests
pull
Enforce that amount is provided for signrawtransaction prevtxs
#12458
Empact on February 16, 2018 RPC/REST/ZMQ
Empact on February 16, 2018 RPC/REST/ZMQ
pull
Assert compressed keys are strictly shorter than regular
#12459
Empact on February 16, 2018 Tests
Empact on February 16, 2018 Tests
pull
Assert CPubKey::ValidLength to the pubkey's header-relevant size
#12460
Empact on February 16, 2018 Refactoring
Empact on February 16, 2018 Refactoring
pull
scripted-diff: Rename key size consts to be relative to their class
#12461
Empact on February 16, 2018 Refactoring
Empact on February 16, 2018 Refactoring
pull
Drop the return and corruptionPossible arguments from CValidationState::DoS, and rename to ::Reject
#12463
Empact on February 16, 2018 Refactoring
Empact on February 16, 2018 Refactoring
pull
Declare CMutableTransaction a struct in rawtransaction.h
#12494
Empact on February 20, 2018 RPC/REST/ZMQ
Empact on February 20, 2018 RPC/REST/ZMQ
pull
Don't test against the mempool min fee information in mempool_limit.py
#12512
Empact on February 22, 2018 Tests
Empact on February 22, 2018 Tests
pull
Expose node relay fee settings in help, independent of -help-debug
#12745
Empact on March 21, 2018 Docs
Empact on March 21, 2018 Docs
pull
Store the current config file at read time, and return it from GetConfigFile if set
#12765
Empact on March 23, 2018 Utils/log/libsUp for grabs
Empact on March 23, 2018 Utils/log/libsUp for grabs
pull
[moveonly] Extract HelpRequested to dry up the help options testing
#12846
Empact on March 30, 2018 Refactoring
Empact on March 30, 2018 Refactoring
pull
Handle witness version and OP_N results as an unsigned char
#12937
Empact on April 11, 2018 Refactoring
Empact on April 11, 2018 Refactoring
pull
rpc: Fix estimatesmartfee to properly handle a null estimate_mode arg
#12940
Empact on April 11, 2018 RPC/REST/ZMQUp for grabs
Empact on April 11, 2018 RPC/REST/ZMQUp for grabs
pull
rpc: Drop redundant testing of signrawtransaction prevtxs args
#12942
Empact on April 11, 2018 RPC/REST/ZMQ
Empact on April 11, 2018 RPC/REST/ZMQ
pull
Drop IsCompressedOrUncompressedPubKey and IsCompressedPubKey
#12959
Empact on April 12, 2018 Refactoring
Empact on April 12, 2018 Refactoring
pull
Remove return and corruptionPossible arguments from DoS, rename to Reject
#12976
Empact on April 13, 2018
Empact on April 13, 2018
pull
scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks
#13016
Empact on April 18, 2018 RefactoringValidation
Empact on April 18, 2018 RefactoringValidation
pull
Consistently log CValidationState on call failure
#13020
Empact on April 18, 2018 Utils/log/libs
Empact on April 18, 2018 Utils/log/libs
pull
Fix ScanForWalletTransactions to return an enum indicating scan result: success / failure / user_abort
#13076
Empact on April 25, 2018 RefactoringWallet
Empact on April 25, 2018 RefactoringWallet
pull
Optimize SelectCoinsBnB by tracking the selection by index rather than by position
#13226
Empact on May 13, 2018 Wallet
Empact on May 13, 2018 Wallet
pull
Break circular dependency: init -> * -> init by extracting shutdown.h
#13235
Empact on May 15, 2018 Refactoring
Empact on May 15, 2018 Refactoring
pull
[moveonly] Fix CConnman template methods to be fully-defined in net.h
#13239
Empact on May 15, 2018 RefactoringP2P
Empact on May 15, 2018 RefactoringP2P
pull
scripted-diff: Avoid temporary copies when looping over std::map
#13241
Empact on May 15, 2018 Refactoring
Empact on May 15, 2018 Refactoring
pull
Wallet: Refactor ReserveKeyFromKeyPool for safety
#13252
Empact on May 17, 2018 RefactoringWallet
Empact on May 17, 2018 RefactoringWallet
pull
Remove improper qt/moc_* cleaning glob from the general Makefile
#13254
Empact on May 17, 2018 Build system
Empact on May 17, 2018 Build system
pull
wallet: Fix ReserveKeyFromKeyPool to always test key classification, even if last in the pool.
#13257
Empact on May 17, 2018
Empact on May 17, 2018
pull
refactor: privatize SignatureExtractorChecker [moveonly]
#13266
Empact on May 18, 2018 Refactoring
Empact on May 18, 2018 Refactoring
pull
refactoring: Clean up GetWitnessCommitmentIndex
#13267
Empact on May 18, 2018 RefactoringValidation
Empact on May 18, 2018 RefactoringValidation
pull
refactoring: Drop UpdateTransaction in favor of UpdateInput
#13269
Empact on May 18, 2018 Refactoring
Empact on May 18, 2018 Refactoring
pull
rpc: Remove the need to include rpc/blockchain.cpp in order to put `GetDifficulty` under test
#13288
Empact on May 20, 2018 RefactoringRPC/REST/ZMQ
Empact on May 20, 2018 RefactoringRPC/REST/ZMQ
pull
test: Don't include torcontrol.cpp into the test file
#13291
Empact on May 21, 2018 RefactoringTests
Empact on May 21, 2018 RefactoringTests
pull
Consistently validate txid / blockhash length and encoding in rpc calls
#13424
Empact on June 8, 2018 Refactoring
Empact on June 8, 2018 Refactoring
pull
When build fails due to lib missing, indicate which one
#13435
Empact on June 11, 2018 Build system
Empact on June 11, 2018 Build system
pull
Make SER_GETHASH implicit for CHashWriter and SerializeHash
#13462
Empact on June 13, 2018 RefactoringNeeds rebase
Empact on June 13, 2018 RefactoringNeeds rebase
pull
policy: Report reason inputs are nonstandard from AreInputsStandard
#13525
Empact on June 23, 2018 TX fees and policy
Empact on June 23, 2018 TX fees and policy
pull
test: Fix AreInputsStandard test to reference the proper scriptPubKey
#13565
Empact on June 28, 2018 Tests
Empact on June 28, 2018 Tests
pull
WIP: bitcoin-tx: Require that input amount is provided for witness transactions
#13608
Empact on July 7, 2018 Utils/log/libs
Empact on July 7, 2018 Utils/log/libs
pull
Drop unused pindexRet arg to CMerkleTx::GetDepthInMainChain
#13630
Empact on July 11, 2018 RefactoringWallet
Empact on July 11, 2018 RefactoringWallet
pull
[refactor] Fix the chainparamsbase -> util circular dependency
#13639
Empact on July 12, 2018 Refactoring
Empact on July 12, 2018 Refactoring
pull
[moveonly] Extract CWallet::MarkInputsDirty, and privatize AddToWalletIfInvolvingMe
#13651
Empact on July 12, 2018 Wallet
Empact on July 12, 2018 Wallet
pull
rpc: Fix that CWallet::AbandonTransaction would leave the grandchildren, etc. active
#13652
Empact on July 12, 2018 Wallet
Empact on July 12, 2018 Wallet
pull
wallet: assert to ensure accuracy of CMerkleTx::GetBlocksToMaturity
#13657
Empact on July 13, 2018 Wallet
Empact on July 13, 2018 Wallet
pull
[moveonly] Extract RescanWallet to handle a simple rescan
#13658
Empact on July 13, 2018 RefactoringWallet
Empact on July 13, 2018 RefactoringWallet
pull
[test] Add coverage to estimaterawfee and estimatesmartfee
#13693
Empact on July 17, 2018 Tests
Empact on July 17, 2018 Tests
pull
travis: Avoid unnecessarily setting env variables on the lint build
#13729
Empact on July 20, 2018 Tests
Empact on July 20, 2018 Tests
pull
Remove unused fScriptChecks parameter from CheckInputs
#13868
Empact on August 3, 2018 RefactoringValidation
Empact on August 3, 2018 RefactoringValidation
pull
Introduce MempoolObserver interface to break "policy/fees -> txmempool -> policy/fees" circular dependency
#13949
Empact on August 13, 2018 RefactoringMempoolNeeds rebase
Empact on August 13, 2018 RefactoringMempoolNeeds rebase
pull
Make IS_TRIVIALLY_CONSTRUCTIBLE consistent on GCC < 5, don't patch clang
#14031
Empact on August 23, 2018 Refactoring
Empact on August 23, 2018 Refactoring
pull
p2p: Drop CADDR_TIME_VERSION checks now that MIN_PEER_PROTO_VERSION is greater
#14033
Empact on August 23, 2018 P2P
Empact on August 23, 2018 P2P
pull
refactor: Fix the chainparamsbase -> util circular dependency
#14045
Empact on August 24, 2018 RefactoringNeeds rebase
Empact on August 24, 2018 RefactoringNeeds rebase
pull
refactor: Lift prevector default vals to the member declaration
#14266
Empact on September 19, 2018 Refactoring
Empact on September 19, 2018 Refactoring
pull
gui: Mark Qt methods as override where appropriate
#14267
Empact on September 19, 2018 GUIRefactoring
Empact on September 19, 2018 GUIRefactoring
pull
Introduce SafeDbt to handle Dbt with free or memory_cleanse raii-style
#14268
Empact on September 19, 2018 Wallet
Empact on September 19, 2018 Wallet
pull
Move urlDecode to wallet/rpcwallet.cpp, where it's used
#14269
Empact on September 19, 2018 RefactoringWallet
Empact on September 19, 2018 RefactoringWallet
pull
Consolidate redundant implementations of ParseHashStr
#14307
Empact on September 24, 2018 Refactoring
Empact on September 24, 2018 Refactoring
pull
tests: Don't access out of bounds array index: array[sizeof(array)]
#14398
Empact on October 5, 2018 Tests
Empact on October 5, 2018 Tests
pull
tests: Separately check for rapidcheck/boost_test.h in configure
#14694
Empact on November 8, 2018 Build system
Empact on November 8, 2018 Build system
pull
build: Drop AC_CHECK_DECLS for unused __builtin_clz
#14747
Empact on November 17, 2018 Build system
Empact on November 17, 2018 Build system
pull
test: Correct ineffectual WithOrVersion from transactions_tests
#14855
Empact on December 2, 2018 Tests
Empact on December 2, 2018 Tests
pull
[WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories lib
#14892
Empact on December 7, 2018
Empact on December 7, 2018
pull
Build: enable -Wdocumentation via isystem
#14920
Empact on December 11, 2018 Build systemNeeds rebase
Empact on December 11, 2018 Build systemNeeds rebase
pull
wallet: Make scan / abort status private to CWallet
#14942
Empact on December 13, 2018 WalletNeeds rebase
Empact on December 13, 2018 WalletNeeds rebase
pull
wallet: Initialize stop_block in CWallet::ScanForWalletTransactions
#14957
Empact on December 14, 2018 Wallet
Empact on December 14, 2018 Wallet
pull
test: Propagate stderr through test_runner failure reporting
#15076
Empact on January 1, 2019 Tests
Empact on January 1, 2019 Tests
pull
build: Optionally enable -Wzero-as-null-pointer-constant
#15112
Empact on January 5, 2019 Build system
Empact on January 5, 2019 Build system
pull
[WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories folder
#15133
Empact on January 9, 2019 Tests
Empact on January 9, 2019 Tests
pull
Docs: Update python docs to reflect that wildcard imports are disallowed
#15249
Empact on January 25, 2019 Docs
Empact on January 25, 2019 Docs
pull
Scripts and tools: Bump flake8 to 3.7.8
#15257
Empact on January 25, 2019 TestsScripts and tools
Empact on January 25, 2019 TestsScripts and tools
pull
Scripts and tools: Fix devtools/copyright_header.py to always honor exclusions
#15258
Empact on January 25, 2019 Scripts and tools
Empact on January 25, 2019 Scripts and tools
pull
build: Restore compatibility with older boost
#15308
Empact on January 31, 2019 RefactoringBuild system
Empact on January 31, 2019 RefactoringBuild system
pull
rpc: Expose g_is_mempool_loaded via getmempoolinfo
#15323
Empact on February 1, 2019 RPC/REST/ZMQ
Empact on February 1, 2019 RPC/REST/ZMQ
pull
build: Disallow shadowing variables via -isystem, -Wshadow
#15377
Empact on February 9, 2019 Build system
Empact on February 9, 2019 Build system
pull
build: Optionally enable -Wthread-safety-attributes
#15556
Empact on March 7, 2019 Build system
Empact on March 7, 2019 Build system
pull
Avoid unnecessary signing provider copies on descriptor expansion
#16116
Empact on May 29, 2019 Wallet
Empact on May 29, 2019 Wallet
pull
Return error information on descriptor parse error
#16123
Empact on May 30, 2019 WalletRPC/REST/ZMQ
Empact on May 30, 2019 WalletRPC/REST/ZMQ
pull
doc/lint: Fix spelling errors identified by codespell 1.15.0
#16186
Empact on June 11, 2019 Docs
Empact on June 11, 2019 Docs
pull
Disallow automatic conversion between disparate hash types
#17938
Empact on January 16, 2020 WalletRPC/REST/ZMQ
Empact on January 16, 2020 WalletRPC/REST/ZMQ
pull
Replace uses of boost::trim* with locale-independent alternatives
#18130
Empact on February 12, 2020 RefactoringNeeds rebase
Empact on February 12, 2020 RefactoringNeeds rebase
pull
Replace std::to_string with locale-independent alternative
#18134
Empact on February 13, 2020 Refactoring
Empact on February 13, 2020 Refactoring
pull
refactor: Consolidate unnecessary base58 interfaces
#18226
Empact on February 28, 2020 Refactoring
Empact on February 28, 2020 Refactoring
pull
refactor: Fix implicit value conversion in formatPingTime
#18260
Empact on March 4, 2020 RefactoringRPC/REST/ZMQ
Empact on March 4, 2020 RefactoringRPC/REST/ZMQ
pull
test: Wait for 'cmpctblock' in p2p_compactblocks when it is expected
#19631
Empact on July 30, 2020 Tests
Empact on July 30, 2020 Tests
pull
test: Catch decimal.InvalidOperation from TestNodeCLI#send_cli
#19632
Empact on July 31, 2020 Tests
Empact on July 31, 2020 Tests
pull
refactor: Split ArgsManager out of util/system
#24455
Empact on March 1, 2022 RefactoringUtils/log/libsNeeds rebase
Empact on March 1, 2022 RefactoringUtils/log/libsNeeds rebase
pull
For descriptor pubkey parse errors, include context information
#24462
Empact on March 2, 2022 Descriptors
Empact on March 2, 2022 Descriptors
pull
refactor: Prepare for moving ArgsManager out of util/system
#24811
Empact on April 8, 2022 RefactoringUtils/log/libsNeeds rebase
Empact on April 8, 2022 RefactoringUtils/log/libsNeeds rebase
pull
refactor: Split util/system into exception, shell, and fs-specific files
#25152
Empact on May 17, 2022 RefactoringNeeds rebase
Empact on May 17, 2022 RefactoringNeeds rebase
pull
doc: Fix spelling errors identified by codespell in comments
#25200
Empact on May 24, 2022 Refactoring
Empact on May 24, 2022 Refactoring
pull
Add warning on first startup if free disk space is less than necessary
#25315
Empact on June 8, 2022
Empact on June 8, 2022
pull
refactor: Extract MIB_BYTES constant for init.cpp
#25386
Empact on June 16, 2022 RefactoringNeeds rebase
Empact on June 16, 2022 RefactoringNeeds rebase
pull
Enable -Wstring-concatenation and -Wstring-conversion on clang builds
#26288
Empact on October 10, 2022 Needs rebaseCI failed
Empact on October 10, 2022 Needs rebaseCI failed
pull
refactor: Extract util/exception from util/system
#26301
Empact on October 12, 2022 Refactoring
Empact on October 12, 2022 Refactoring
Issues