default address format in bitcoin-qt 0.16 is p2sh-wrapped segwit. should the example not also be p2sh?
[gui] Use base58 script hash address as example #12599
pull bill-walker wants to merge 2 commits into bitcoin:master from bill-walker:master changing 4 files +43 −4-
bill-walker commented at 8:35 PM on March 4, 2018: none
-
testing for script hash example address 721c978a17
-
bill-walker commented at 8:40 PM on March 4, 2018: none
this is for the qt client. easy to review, only 6 bytes difference.
- bill-walker renamed this:
testing for script hash example address
testing for script hash example address in bitcoin-qt client
on Mar 4, 2018 - bill-walker renamed this:
testing for script hash example address in bitcoin-qt client
script hash example address in bitcoin-qt client
on Mar 4, 2018 -
achow101 commented at 8:57 PM on March 4, 2018: member
What is the point of this change?
-
randolf commented at 8:59 PM on March 4, 2018: contributor
You've asked questions but not explained what the intention of this change is. I suspect it may be better-suited to being submitted as an "Issue" rather than as a "Pull Request."
-
sipa commented at 8:59 PM on March 4, 2018: member
It may make sense; the default address type will be a P2SH one now.
-
bill-walker commented at 5:27 AM on March 5, 2018: none
i don't often check my email. is this something i should have sent to the mailing list?
- MarcoFalke added the label GUI on Mar 5, 2018
-
laanwj commented at 4:24 PM on March 5, 2018: member
Yes, why not... Though there's no hurry - I suppose the example address should look like the address type that is most used in the wild.
i don't often check my email. is this something i should have sent to the mailing list?
No, making a github PR is exactly right for code change proposals. The bitcoin-dev mailing list is used for higher-level ideas (e.g. BIPs), the bitcoin-core-dev list is pretty much only used for announcements.
- MarcoFalke renamed this:
script hash example address in bitcoin-qt client
[gui] Use base58 script hash address as example
on Mar 13, 2018 -
MarcoFalke commented at 4:57 PM on March 13, 2018: member
Tend to NACK. This implies that one can sign messages with p2sh addresses, which is not true and throws an error.
-
bill-walker commented at 9:00 AM on March 14, 2018: none
This implies that one can sign messages with p2sh addresses
The current default is base58 p2pkh, which is a hash. without revealing the pubkey, can't sign with that either.
Where is the option to sign messages in the bitcoin-qt client? I don't see one.
correction, it's a pubkey, not a pubkey hash. this is for the bitcoin-qt client, which does not allow signing in the gui as far as I know.
further correction: never mind, your point is valid. Signing from the GUI does display a pubkey address.
-
script hash addresses for sending, not for signing a488e9b424
-
bill-walker commented at 9:23 AM on March 14, 2018: none
i will make a new pull request which will only change the sending addresses, not signing addresses.
- bill-walker closed this on Mar 14, 2018
- MarcoFalke locked this on Sep 8, 2021
