pull request to change all dummy addresses to script addresses was a bad idea, since signing with script address is not possible. this PR keeps pubkey addresses for signing example addresses.
I am unfamiliar with git, which is why I reset this repository.
If someone else can do this better in C++, then good luck. Perhaps the type of dummy address can be a parameter in the setupAddressWidget function.
build failed, my C++ is not yet good enough to implement this change.
error: ‘setupScriptAddressWidget’ is not a member of ‘GUIUtil’
pull request to change all dummy addresses to script addresses was a bad idea
I'd prefer to just revert that then?
This seems incredibly circuitous for something that isn't important in the first place.
... when did that get merged anyway?
Oh this is based on #12599 which wasn't merged. In which case: NACK. Let's just keep the code as it is.