[depends] Revert “ccache 3.4.1” #12606

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1803-dependsCCache changing 2 files +3 −3
  1. MarcoFalke commented at 9:40 pm on March 5, 2018: member

    According to #12515 cross-compiling for windows on linux requires a work-around. I believe that for this reason, the nightly builds for linux and windows are not available: https://bitcoin.jonasschnelli.ch/build/522

    It should be safe to just revert to the previously known-to-be-working version of ccache.

    Fixes #12515

    Reverts one commit of #12402

  2. Revert "[depends] ccache 3.4.1"
    This reverts commit 61647a4b868f3d798cdac2404de0f474720ba1fa.
    faf8994c8d
  3. MarcoFalke added the label Build system on Mar 5, 2018
  4. laanwj commented at 9:46 pm on March 5, 2018: member

    Will this bring back the problem @achow101 reported in #12402 (comment) ?

    It looks like ccache’s bundled zlib is failing to build with mingw which is causing #12515. This was also reported in IRC as causing an issue with a new gitian setup.

  5. MarcoFalke commented at 9:50 pm on March 5, 2018: member
    @laanwj The problem exists in 3.4.1 (our current version) and is fixed in 3.4.2 (which is not yet released). I think we can also fix it by reverting to 3.3.4.
  6. laanwj commented at 9:53 pm on March 5, 2018: member

    Oops, sorry, I was confused there, then.

    I think we can also fix it by reverting to 3.3.4.

    An alternative just mentioned @theuni was to remove ccache from the depends, and have it use the OS’s ccache if installed and none if not.

  7. achow101 commented at 9:58 pm on March 5, 2018: member
    utACK faf8994c8d07cb260b054944bb8a85dc145b777d
  8. laanwj commented at 10:08 pm on March 5, 2018: member

    utACK https://github.com/bitcoin/bitcoin/commit/faf8994c8d07cb260b054944bb8a85dc145b777d, if this fixes the issue for now. Other solutions can be pursued later.

    On second thought, this will cause travis to rebuild everything (all the depends) as everything depends on ccache, so better to merge only one change, and @fanquake is already working on a PR that will completely retire ccache. So better to hold off merging this for now.

  9. MarcoFalke closed this on Mar 6, 2018

  10. MarcoFalke deleted the branch on Mar 6, 2018
  11. MarcoFalke referenced this in commit 29fad97c32 on Mar 8, 2018
  12. codablock referenced this in commit 1ef70ac9ef on Nov 4, 2019
  13. barrystyle referenced this in commit 347d8b8bea on Jan 22, 2020
  14. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me