no more double timestamps in debug.log #1262

• ensure that no double timestamps show up in the debug.log, by removing manual timestamps from the source (now only -logtimestamps parameter adds timestamps to debug.log)

I'm kind of inclined to say that we should just remove all the timestamps in messages. It would be a lot cleaner then the conditional printfs in the patch. If timestamps are off we could occasionally write markers in the log (E.g. once an hour, and at startup and shutdown).

(I would just say we should enable timestamps always— but I wouldn't want to make it more attractive for people to compromise bitcoin nodes in order to track the propagation of transactions)

If I had a wish, I would remove all additional timestamps from the source and only rely on the -logtimestamps switch, as this is way cleaner. Perhaps we can force -logtimestamps, if one enables -debug!?

I don't see how moving the conditional time output out of printf makes any difference?

Edit: my mistake, I misread the source changes. I assumed the double timestamps were caused by two threads trying to write to debug at once.

sipa: I have the impression if you use -logtimestamps and add a timestamp manually like in the places I changed in the code you get something like: "05/11/12 18:10:37 05/11/12 18:10:37 sending: getdata (37 bytes)"

And that was what I'm trying to fix ;).

So, remove the manual timestamps? @gmaxwell Is -timestamps default to on really a security issue?

Since no one is protesting I think you should just go remove the manual timestamps.

As far as security goes,— we log too much that would be valuable to someone collecting logs already. Timestamps by default would make it worse. I've seldom wished there were there in logs other people have given me in any case.

Rebased and updated to remove manual timestamps!

since no one protested…